Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-36412: [Python][CI] Fix extra deprecation warnings in the pandas nightly build #39609

Merged
merged 16 commits into from
Jan 17, 2024

Conversation

AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Jan 15, 2024

Fixes left deprecation warnings coming from the pandas development version, by updating our test code to avoid the deprecated patterns.

@AlenkaF AlenkaF changed the title GH-36412: Fix estra deprecation warnings in the pandas nightly build GH-36412: [Python][CI] Fix extra deprecation warnings in the pandas nightly build Jan 15, 2024
@github-actions github-actions bot added the awaiting review Awaiting review label Jan 15, 2024
@AlenkaF
Copy link
Member Author

AlenkaF commented Jan 15, 2024

@github-actions crossbow submit test-conda-python-3.10-pandas-nightly

Copy link

Revision: 7230b6f

Submitted crossbow builds: ursacomputing/crossbow @ actions-40718f16dc

Task Status
test-conda-python-3.10-pandas-nightly GitHub Actions

@AlenkaF
Copy link
Member Author

AlenkaF commented Jan 15, 2024

@github-actions crossbow submit test-conda-python-3.10-pandas-nightly

Copy link

Revision: 0d7edf3

Submitted crossbow builds: ursacomputing/crossbow @ actions-f2bde2fa12

Task Status
test-conda-python-3.10-pandas-nightly GitHub Actions

@AlenkaF
Copy link
Member Author

AlenkaF commented Jan 16, 2024

@github-actions crossbow submit test-conda-python-3.10-pandas-nightly

Copy link

Revision: 09f2f50

Submitted crossbow builds: ursacomputing/crossbow @ actions-3a8abeda7e

Task Status
test-conda-python-3.10-pandas-nightly GitHub Actions

python/pyarrow/tests/test_dataset.py Outdated Show resolved Hide resolved
python/pyarrow/tests/test_dataset.py Outdated Show resolved Hide resolved
python/pyarrow/tests/test_pandas.py Outdated Show resolved Hide resolved
python/pyarrow/pandas_compat.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting review Awaiting review awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Jan 16, 2024
Co-authored-by: Joris Van den Bossche <[email protected]>
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review awaiting changes Awaiting changes labels Jan 16, 2024
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jan 16, 2024
@AlenkaF
Copy link
Member Author

AlenkaF commented Jan 16, 2024

@github-actions crossbow submit test-conda-python-3.10-pandas-nightly

Copy link

Revision: 3adf04e

Submitted crossbow builds: ursacomputing/crossbow @ actions-5666ccb6e4

Task Status
test-conda-python-3.10-pandas-nightly GitHub Actions

@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 16, 2024
@AlenkaF
Copy link
Member Author

AlenkaF commented Jan 16, 2024

@github-actions crossbow submit test-conda-python-3.10-pandas-nightly

Copy link

Revision: 01980c1

Submitted crossbow builds: ursacomputing/crossbow @ actions-db434e524e

Task Status
test-conda-python-3.10-pandas-nightly GitHub Actions

@AlenkaF
Copy link
Member Author

AlenkaF commented Jan 16, 2024

I think this PR looks good now.

The only missing thing I have to solve is this warning about comparison with empty arrays (coming from pandas.testing.assert_frame_equal):

=============================== warnings summary ===============================
opt/conda/envs/arrow/lib/python3.10/site-packages/pyarrow/tests/test_pandas.py::TestConvertMetadata::test_empty_list_metadata
opt/conda/envs/arrow/lib/python3.10/site-packages/pyarrow/tests/test_pandas.py::TestConvertListTypes::test_empty_list_roundtrip
  /opt/conda/envs/arrow/lib/python3.10/site-packages/pandas/core/dtypes/missing.py:578: DeprecationWarning: The truth value of an empty array is ambiguous. Returning False, but in future this will result in an error. Use `array.size > 0` to check that an array is not empty.
    return lib.array_equivalent_object(left, right)

opt/conda/envs/arrow/lib/python3.10/site-packages/pyarrow/tests/test_pandas.py: 2 warnings
opt/conda/envs/arrow/lib/python3.10/site-packages/pyarrow/tests/parquet/test_data_types.py: 3 warnings
opt/conda/envs/arrow/lib/python3.10/site-packages/pyarrow/tests/parquet/test_pandas.py: 2 warnings
opt/conda/envs/arrow/lib/python3.10/site-packages/pyarrow/tests/parquet/test_parquet_file.py: 6 warnings
  /opt/conda/envs/arrow/lib/python3.10/site-packages/pandas/core/dtypes/missing.py:579: DeprecationWarning: The truth value of an empty array is ambiguous. Returning False, but in future this will result in an error. Use `array.size > 0` to check that an array is not empty.
    if not lib.array_equivalent_object(left[~mask], right[~mask]):

But I would do this in a separate PR.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jan 17, 2024
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels Jan 17, 2024
@jorisvandenbossche jorisvandenbossche merged commit 6eeee3b into apache:main Jan 17, 2024
14 checks passed
@jorisvandenbossche jorisvandenbossche removed the awaiting merge Awaiting merge label Jan 17, 2024
@AlenkaF AlenkaF deleted the gh-36412-pandas-warnings branch January 17, 2024 10:26
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 6eeee3b.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

idailylife pushed a commit to idailylife/arrow that referenced this pull request Jan 18, 2024
…ndas nightly build (apache#39609)

Fixes left deprecation warnings coming from the pandas development version, by updating our test code to avoid the deprecated patterns.
* Closes: apache#36412

Lead-authored-by: AlenkaF <[email protected]>
Co-authored-by: Alenka Frim <[email protected]>
Co-authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
clayburn pushed a commit to clayburn/arrow that referenced this pull request Jan 23, 2024
…ndas nightly build (apache#39609)

Fixes left deprecation warnings coming from the pandas development version, by updating our test code to avoid the deprecated patterns.
* Closes: apache#36412

Lead-authored-by: AlenkaF <[email protected]>
Co-authored-by: Alenka Frim <[email protected]>
Co-authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…ndas nightly build (apache#39609)

Fixes left deprecation warnings coming from the pandas development version, by updating our test code to avoid the deprecated patterns.
* Closes: apache#36412

Lead-authored-by: AlenkaF <[email protected]>
Co-authored-by: Alenka Frim <[email protected]>
Co-authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Feb 28, 2024
…ndas nightly build (apache#39609)

Fixes left deprecation warnings coming from the pandas development version, by updating our test code to avoid the deprecated patterns.
* Closes: apache#36412

Lead-authored-by: AlenkaF <[email protected]>
Co-authored-by: Alenka Frim <[email protected]>
Co-authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Mar 8, 2024
…ndas nightly build (apache#39609)

Fixes left deprecation warnings coming from the pandas development version, by updating our test code to avoid the deprecated patterns.
* Closes: apache#36412

Lead-authored-by: AlenkaF <[email protected]>
Co-authored-by: Alenka Frim <[email protected]>
Co-authored-by: Joris Van den Bossche <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python][CI] Fix deprecation warnings in the pandas nightly build
2 participants