-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44342: [C++] Disable jemalloc by default on ARM #44380
Conversation
jemalloc may have a problem on ARM. See also: apache#44342
6dc6509
to
a5bdd21
Compare
@github-actions crossbow submit wheel-manylinux-* |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit wheel-manylinux-* |
Revision: a3e42bb Submitted crossbow builds: ursacomputing/crossbow @ actions-2eedec14c3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
### Rationale for this change jemalloc may have a problem on ARM. See also: #44342 ### What changes are included in this PR? * Disable jemalloc by default on ARM. * Disable jemalloc for manylinux wheel for ARM. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #44342 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 27e56f0. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
jemalloc may have a problem on ARM.
See also: #44342
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.