Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44342: [C++] Disable jemalloc by default on ARM #44380

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

kou
Copy link
Member

@kou kou commented Oct 11, 2024

Rationale for this change

jemalloc may have a problem on ARM.
See also: #44342

What changes are included in this PR?

  • Disable jemalloc by default on ARM.
  • Disable jemalloc for manylinux wheel for ARM.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

jemalloc may have a problem on ARM.
See also: apache#44342
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Oct 11, 2024
@kou
Copy link
Member Author

kou commented Oct 11, 2024

@github-actions crossbow submit wheel-manylinux-*

This comment was marked as outdated.

Copy link

⚠️ GitHub issue #44342 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member Author

kou commented Oct 11, 2024

@github-actions crossbow submit wheel-manylinux-*

Copy link

Revision: a3e42bb

Submitted crossbow builds: ursacomputing/crossbow @ actions-2eedec14c3

Task Status
wheel-manylinux-2-28-cp310-cp310-amd64 GitHub Actions
wheel-manylinux-2-28-cp310-cp310-arm64 GitHub Actions
wheel-manylinux-2-28-cp311-cp311-amd64 GitHub Actions
wheel-manylinux-2-28-cp311-cp311-arm64 GitHub Actions
wheel-manylinux-2-28-cp312-cp312-amd64 GitHub Actions
wheel-manylinux-2-28-cp312-cp312-arm64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313-amd64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313-arm64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-amd64 GitHub Actions
wheel-manylinux-2-28-cp313-cp313t-arm64 GitHub Actions
wheel-manylinux-2-28-cp39-cp39-amd64 GitHub Actions
wheel-manylinux-2-28-cp39-cp39-arm64 GitHub Actions
wheel-manylinux-2014-cp310-cp310-amd64 GitHub Actions
wheel-manylinux-2014-cp310-cp310-arm64 GitHub Actions
wheel-manylinux-2014-cp311-cp311-amd64 GitHub Actions
wheel-manylinux-2014-cp311-cp311-arm64 GitHub Actions
wheel-manylinux-2014-cp312-cp312-amd64 GitHub Actions
wheel-manylinux-2014-cp312-cp312-arm64 GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64 GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64 GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64 GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64 GitHub Actions
wheel-manylinux-2014-cp39-cp39-amd64 GitHub Actions
wheel-manylinux-2014-cp39-cp39-arm64 GitHub Actions

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raulcd raulcd merged commit 27e56f0 into apache:main Oct 14, 2024
36 checks passed
@raulcd raulcd removed the awaiting committer review Awaiting committer review label Oct 14, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Oct 14, 2024
raulcd pushed a commit that referenced this pull request Oct 14, 2024
### Rationale for this change

jemalloc may have a problem on ARM.
See also: #44342

### What changes are included in this PR?

* Disable jemalloc by default on ARM.
* Disable jemalloc for manylinux wheel for ARM.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.

* GitHub Issue: #44342

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 27e56f0.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

@kou kou deleted the cpp-jemalloc-aarch64 branch October 15, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants