Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44667: [Archery] Suppress pull/push progress logs #44669

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

kou
Copy link
Member

@kou kou commented Nov 7, 2024

Rationale for this change

They are useless and noisy in CI log.

What changes are included in this PR?

Add the --quiet option to docker pull/docker push.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou
Copy link
Member Author

kou commented Nov 7, 2024

@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64

Copy link

github-actions bot commented Nov 7, 2024

⚠️ GitHub issue #44667 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

Revision: 30ff1a4

Submitted crossbow builds: ursacomputing/crossbow @ actions-76ade52013

Task Status
wheel-manylinux-2-28-cp39-cp39-amd64 GitHub Actions

@kou
Copy link
Member Author

kou commented Nov 7, 2024

@github-actions crossbow submit wheel-manylinux-2-28-cp39-cp39-amd64

Copy link

github-actions bot commented Nov 7, 2024

Revision: 5e4e872

Submitted crossbow builds: ursacomputing/crossbow @ actions-4ba13d3a22

Task Status
wheel-manylinux-2-28-cp39-cp39-amd64 GitHub Actions

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Nov 8, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Nov 8, 2024
@assignUser assignUser merged commit f28ba44 into apache:main Nov 8, 2024
9 checks passed
@assignUser assignUser removed the awaiting change review Awaiting change review label Nov 8, 2024
@kou kou deleted the archery-docker-progress branch November 8, 2024 22:17
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f28ba44.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

pitrou added a commit that referenced this pull request Nov 28, 2024
…n CI (#44865)

### Rationale for this change

#44669 went overboard by always suppressing Docker progress output. This may be desirable on CI, to avoid flooding the logs, but is annoying when running `archery docker` locally.

### What changes are included in this PR?

Only suppress Docker progress output if on CI.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes, this restores the previous behavior for non-CI runs.

* GitHub Issue: #44878

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants