[WIP] Add a gcc 15 CI job #44970

jonkeane · 2024-12-09T03:43:19Z

I'll make an issue if this works, but checking to see if I can replicate an error I see on CRAN.

...
[ 86%] �[32mBuilding CXX object lib/cpp/CMakeFiles/thrift.dir/src/thrift/transport/TSSLServerSocket.cpp.o�[0m
make[7]: Leaving directory '/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep-build'
make[6]: Leaving directory '/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep-build'
make[5]: Leaving directory '/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep-build'

-- stderr output is:
...skipping to end...
terator�[m�[K' is deprecated [�[01;35m�[K-Wdeprecated-declarations�[m�[K]
   54 |     : public std::�[01;35m�[Kiterator�[m�[K<std::forward_iterator_tag, std::pair<int, const char*> > {
      |                   �[01;35m�[K^~~~~~~~�[m�[K
In file included from �[01m�[K/usr/local/gcc15/include/c++/15.0.0/bits/stl_construct.h:61�[m�[K,
                 from �[01m�[K/usr/local/gcc15/include/c++/15.0.0/bits/stl_tempbuf.h:61�[m�[K,
                 from �[01m�[K/usr/local/gcc15/include/c++/15.0.0/memory:68�[m�[K,
                 from �[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TSSLSocket.cpp:24�[m�[K:
�[01m�[K/usr/local/gcc15/include/c++/15.0.0/bits/stl_iterator_base_types.h:129:34:�[m�[K �[01;36m�[Knote: �[m�[Kdeclared here
  129 |     struct _GLIBCXX17_DEPRECATED �[01;36m�[Kiterator�[m�[K
      |                                  �[01;36m�[K^~~~~~~~�[m�[K
�[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TSSLSocket.cpp:�[m�[K In constructor '�[01m�[Kapache::thrift::transport::SSLContext::�[01;32m�[KSSLContext�[m�[K(const apache::thrift::transport::SSLProtocol&)�[m�[K':
�[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TSSLSocket.cpp:185:36:�[m�[K �[01;35m�[Kwarning: �[m�[K'�[01m�[Kconst SSL_METHOD*�[01;32m�[K TLSv1_method�[m�[K()�[m�[K' is deprecated: Since OpenSSL 1.1.0 [�[01;35m�[K-Wdeprecated-declarations�[m�[K]
  185 |     ctx_ = SSL_CTX_new(�[01;35m�[KTLSv1_method()�[m�[K);
      |                        �[01;35m�[K~~~~~~~~~~~~^~�[m�[K
In file included from �[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TSSLSocket.cpp:53�[m�[K:
�[01m�[K/usr/include/openssl/ssl.h:2020:50:�[m�[K �[01;36m�[Knote: �[m�[Kdeclared here
 2020 | OSSL_DEPRECATEDIN_1_1_0 __owur const SSL_METHOD *�[01;36m�[KTLSv1_method�[m�[K(void); /* TLSv1.0 */
      |                                                  �[01;36m�[K^~~~~~~~~~~~�[m�[K
�[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TSSLSocket.cpp:187:38:�[m�[K �[01;35m�[Kwarning: �[m�[K'�[01m�[Kconst SSL_METHOD*�[01;32m�[K TLSv1_1_method�[m�[K()�[m�[K' is deprecated: Since OpenSSL 1.1.0 [�[01;35m�[K-Wdeprecated-declarations�[m�[K]
  187 |     ctx_ = SSL_CTX_new(�[01;35m�[KTLSv1_1_method()�[m�[K);
      |                        �[01;35m�[K~~~~~~~~~~~~~~^~�[m�[K
�[01m�[K/usr/include/openssl/ssl.h:2028:50:�[m�[K �[01;36m�[Knote: �[m�[Kdeclared here
 2028 | OSSL_DEPRECATEDIN_1_1_0 __owur const SSL_METHOD *�[01;36m�[KTLSv1_1_method�[m�[K(void); /* TLSv1.1 */
      |                                                  �[01;36m�[K^~~~~~~~~~~~~~�[m�[K
�[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TSSLSocket.cpp:189:38:�[m�[K �[01;35m�[Kwarning: �[m�[K'�[01m�[Kconst SSL_METHOD*�[01;32m�[K TLSv1_2_method�[m�[K()�[m�[K' is deprecated: Since OpenSSL 1.1.0 [�[01;35m�[K-Wdeprecated-declarations�[m�[K]
  189 |     ctx_ = SSL_CTX_new(�[01;35m�[KTLSv1_2_method()�[m�[K);
      |                        �[01;35m�[K~~~~~~~~~~~~~~^~�[m�[K
�[01m�[K/usr/include/openssl/ssl.h:2036:50:�[m�[K �[01;36m�[Knote: �[m�[Kdeclared here
 2036 | OSSL_DEPRECATEDIN_1_1_0 __owur const SSL_METHOD *�[01;36m�[KTLSv1_2_method�[m�[K(void); /* TLSv1.2 */
      |                                                  �[01;36m�[K^~~~~~~~~~~~~~�[m�[K
�[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TSSLSocket.cpp:�[m�[K In member function '�[01m�[Kvirtual void apache::thrift::transport::TSSLSocket::�[01;32m�[Kauthorize�[m�[K()�[m�[K':
�[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TSSLSocket.cpp:758:43:�[m�[K �[01;35m�[Kwarning: �[m�[K'�[01m�[Kunsigned char*�[01;32m�[K ASN1_STRING_data�[m�[K(ASN1_STRING*)�[m�[K' is deprecated: Since OpenSSL 1.1.0 [�[01;35m�[K-Wdeprecated-declarations�[m�[K]
  758 |       char* data = (char*)�[01;35m�[KASN1_STRING_data(name->d.ia5)�[m�[K;
      |                           �[01;35m�[K~~~~~~~~~~~~~~~~^~~~~~~~~~~~~�[m�[K
In file included from �[01m�[K/usr/include/openssl/objects.h:21�[m�[K,
                 from �[01m�[K/usr/include/openssl/evp.h:43�[m�[K,
                 from �[01m�[K/usr/include/openssl/rand.h:23�[m�[K,
                 from �[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TSSLSocket.cpp:52�[m�[K:
�[01m�[K/usr/include/openssl/asn1.h:680:40:�[m�[K �[01;36m�[Knote: �[m�[Kdeclared here
  680 | OSSL_DEPRECATEDIN_1_1_0 unsigned char *�[01;36m�[KASN1_STRING_data�[m�[K(ASN1_STRING *x);
      |                                        �[01;36m�[K^~~~~~~~~~~~~~~~�[m�[K
�[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TSSLSocket.cpp:�[m�[K At global scope:
�[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TSSLSocket.cpp:111:13:�[m�[K �[01;35m�[Kwarning: �[m�[K'�[01m�[Kvoid apache::thrift::transport::�[01;32m�[Kdyn_destroy�[m�[K(CRYPTO_dynlock_value*, const char*, int)�[m�[K' defined but not used [�[01;35m�[K-Wunused-function�[m�[K]
  111 | static void �[01;35m�[Kdyn_destroy�[m�[K(struct CRYPTO_dynlock_value* lock, const char*, int) {
      |             �[01;35m�[K^~~~~~~~~~~�[m�[K
�[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TSSLSocket.cpp:101:13:�[m�[K �[01;35m�[Kwarning: �[m�[K'�[01m�[Kvoid apache::thrift::transport::�[01;32m�[Kdyn_lock�[m�[K(int, CRYPTO_dynlock_value*, const char*, int)�[m�[K' defined but not used [�[01;35m�[K-Wunused-function�[m�[K]
  101 | static void �[01;35m�[Kdyn_lock�[m�[K(int mode, struct CRYPTO_dynlock_value* lock, const char*, int) {
      |             �[01;35m�[K^~~~~~~~�[m�[K
�[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TSSLSocket.cpp:97:30:�[m�[K �[01;35m�[Kwarning: �[m�[K'�[01m�[KCRYPTO_dynlock_value* apache::thrift::transport::�[01;32m�[Kdyn_create�[m�[K(const char*, int)�[m�[K' defined but not used [�[01;35m�[K-Wunused-function�[m�[K]
   97 | static CRYPTO_dynlock_value* �[01;35m�[Kdyn_create�[m�[K(const char*, int) {
      |                              �[01;35m�[K^~~~~~~~~~�[m�[K
�[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TSSLSocket.cpp:76:13:�[m�[K �[01;35m�[Kwarning: �[m�[K'�[01m�[Kvoid apache::thrift::transport::�[01;32m�[KcallbackLocking�[m�[K(int, int, const char*, int)�[m�[K' defined but not used [�[01;35m�[K-Wunused-function�[m�[K]
   76 | static void �[01;35m�[KcallbackLocking�[m�[K(int mode, int n, const char*, int) {
      |             �[01;35m�[K^~~~~~~~~~~~~~~�[m�[K
In file included from �[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TServerSocket.h:25�[m�[K,
                 from �[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TSSLServerSocket.h:23�[m�[K,
                 from �[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TSSLServerSocket.cpp:21�[m�[K:
�[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/concurrency/Mutex.h:47:26:�[m�[K �[01;31m�[Kerror: �[m�[K'�[01m�[Kint64_t�[m�[K' has not been declared
   47 |   virtual bool timedlock(�[01;31m�[Kint64_t�[m�[K milliseconds) const;
      |                          �[01;31m�[K^~~~~~~�[m�[K
�[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/concurrency/Mutex.h:60:29:�[m�[K �[01;31m�[Kerror: �[m�[K'�[01m�[Kint64_t�[m�[K' has not been declared
   60 |   Guard(const Mutex& value, �[01;31m�[Kint64_t�[m�[K timeout = 0) : mutex_(&value) {
      |                             �[01;31m�[K^~~~~~~�[m�[K
In file included from �[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TTransport.h:23�[m�[K,
                 from �[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TServerTransport.h:23�[m�[K,
                 from �[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TServerSocket.h:27�[m�[K:
�[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/Thrift.h:54:19:�[m�[K �[01;35m�[Kwarning: �[m�[K'�[01m�[Ktemplate<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator�[m�[K' is deprecated [�[01;35m�[K-Wdeprecated-declarations�[m�[K]
   54 |     : public std::�[01;35m�[Kiterator�[m�[K<std::forward_iterator_tag, std::pair<int, const char*> > {
      |                   �[01;35m�[K^~~~~~~~�[m�[K
In file included from �[01m�[K/usr/local/gcc15/include/c++/15.0.0/bits/stl_algobase.h:65�[m�[K,
                 from �[01m�[K/usr/local/gcc15/include/c++/15.0.0/bits/hashtable_policy.h:36�[m�[K,
                 from �[01m�[K/usr/local/gcc15/include/c++/15.0.0/bits/hashtable.h:37�[m�[K,
                 from �[01m�[K/usr/local/gcc15/include/c++/15.0.0/bits/unordered_map.h:33�[m�[K,
                 from �[01m�[K/usr/local/gcc15/include/c++/15.0.0/unordered_map:43�[m�[K,
                 from �[01m�[K/usr/local/gcc15/include/c++/15.0.0/functional:65�[m�[K,
                 from �[01m�[K/tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/transport/TServerSocket.h:23�[m�[K:
�[01m�[K/usr/local/gcc15/include/c++/15.0.0/bits/stl_iterator_base_types.h:129:34:�[m�[K �[01;36m�[Knote: �[m�[Kdeclared here
  129 |     struct _GLIBCXX17_DEPRECATED �[01;36m�[Kiterator�[m�[K
      |                                  �[01;36m�[K^~~~~~~~�[m�[K
make[7]: *** [lib/cpp/CMakeFiles/thrift.dir/build.make:580: lib/cpp/CMakeFiles/thrift.dir/src/thrift/transport/TSSLServerSocket.cpp.o] Error 1
make[6]: *** [CMakeFiles/Makefile2:152: lib/cpp/CMakeFiles/thrift.dir/all] Error 2
make[5]: *** [Makefile:156: all] Error 2

�[31mCMake Error at /tmp/RtmpBlv7cn/file362bcd655fc78c/thrift_ep-prefix/src/thrift_ep-stamp/thrift_ep-build-RELEASE.cmake:47 (message):
  Stopping after outputting logs.

�[0m
make[4]: *** [CMakeFiles/thrift_ep.dir/build.make:86: thrift_ep-prefix/src/thrift_ep-stamp/thrift_ep-build] Error 1
make[4]: Leaving directory '/tmp/RtmpBlv7cn/file362bcd655fc78c'
make[3]: *** [CMakeFiles/Makefile2:878: CMakeFiles/thrift_ep.dir/all] Error 2
make[3]: *** Waiting for unfinished jobs....
-- re2_ep build command succeeded.  See also /tmp/RtmpBlv7cn/file362bcd655fc78c/re2_ep-prefix/src/re2_ep-stamp/re2_ep-build-*.log
[ 11%] �[34m�[1mPerforming install step for 're2_ep'�[0m
-- re2_ep install command succeeded.  See also /tmp/RtmpBlv7cn/file362bcd655fc78c/re2_ep-prefix/src/re2_ep-stamp/re2_ep-install-*.log
[ 11%] �[34m�[1mCompleted 're2_ep'�[0m
make[4]: Leaving directory '/tmp/RtmpBlv7cn/file362bcd655fc78c'
[ 11%] Built target re2_ep
make[3]: Leaving directory '/tmp/RtmpBlv7cn/file362bcd655fc78c'
gmake[2]: *** [Makefile:146: all] Error 2
gmake[2]: Leaving directory '/tmp/RtmpBlv7cn/file362bcd655fc78c'
**** Complete build log may still be present at /tmp/RtmpBlv7cn/file362bcd68e7503e.log 
*** Failed to find Arrow C++ libraries.
...

jonkeane · 2024-12-09T03:43:37Z

@github-acations crossbow submit test-ubuntu-24.04-cpp-gcc-15

jonkeane · 2024-12-09T03:50:54Z

@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-15

github-actions · 2024-12-09T03:53:07Z

Revision: b3d1413

Submitted crossbow builds: ursacomputing/crossbow @ actions-a3d143f3a6

Task	Status
test-ubuntu-24.04-cpp-gcc-15

jonkeane · 2024-12-09T04:13:20Z

@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-15

github-actions · 2024-12-09T04:15:37Z

Revision: bd4d541

Submitted crossbow builds: ursacomputing/crossbow @ actions-5fde65e116

Task	Status
test-ubuntu-24.04-cpp-gcc-15

jonkeane · 2024-12-09T04:23:15Z

@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-15

github-actions · 2024-12-09T04:25:28Z

Revision: a3d5e63

Submitted crossbow builds: ursacomputing/crossbow @ actions-0f7b7b1b7b

Task	Status
test-ubuntu-24.04-cpp-gcc-15

jonkeane · 2024-12-09T04:35:28Z

@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-15

github-actions · 2024-12-09T04:37:39Z

Revision: d7ee6f7

Submitted crossbow builds: ursacomputing/crossbow @ actions-f3468f1f37

Task	Status
test-ubuntu-24.04-cpp-gcc-15

pitrou · 2024-12-09T14:38:33Z

dev/tasks/tasks.yml

+    params:
+      env:
+        CLANG_TOOLS: 15
+        GCC_VERSION: snapshot


Hmm, I'm not sure what this is supposed to mean, but FTR we would only like to test against a released gcc version.

I'm trying to get a CI job up that tests what CRAN is testing at https://www.stats.ox.ac.uk/pub/bdr/gcc15/arrow.out Which, is indeed the unreleased GCC. I haven't (yet) gotten an email asking us to fix this, but we have in the past been asked to fix things that error on even unreleased compilers. (Yes, I know this sounds absurd, nevertheless it's the way CRAN works).

We won't need to even run it nightly (CRAN does that for us to an extent), but having something that lets us check and confirm if our fix worked would be lovely.

jonkeane · 2024-12-10T20:07:01Z

@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-15

github-actions · 2024-12-10T20:09:20Z

Revision: 8f235bd

Submitted crossbow builds: ursacomputing/crossbow @ actions-0f249c30ab

Task	Status
test-ubuntu-24.04-cpp-gcc-15

jonkeane · 2024-12-10T20:23:41Z

@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-15

github-actions · 2024-12-10T20:26:06Z

Revision: 7fa1d13

Submitted crossbow builds: ursacomputing/crossbow @ actions-172fc52ab3

Task	Status
test-ubuntu-24.04-cpp-gcc-15

jonkeane · 2024-12-10T20:52:25Z

@github-actions crossbow submit test-ubuntu-24.04-cpp-gcc-15

github-actions · 2024-12-10T20:54:40Z

Revision: 3bd2d90

Submitted crossbow builds: ursacomputing/crossbow @ actions-6449e677aa

Task	Status
test-ubuntu-24.04-cpp-gcc-15

jonkeane · 2024-12-10T21:24:29Z

I'm giving up on this for now, hopefully CRAN won't ask us to fix this before 15 is released

Add a gcc 15 job

b3d1413

github-actions bot added the awaiting committer review Awaiting committer review label Dec 9, 2024

try snapshot

bd4d541

no g++ snapshot

a3d5e63

try snapshot

d7ee6f7

pitrou reviewed Dec 9, 2024

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Dec 9, 2024

this?

8f235bd

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Dec 10, 2024

ugh

7fa1d13

ugh

3bd2d90

jonkeane closed this Dec 10, 2024

jonkeane mentioned this pull request Dec 22, 2024

[R][C++] Passing builds on (unreleased) GCC 15 #45096

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Add a gcc 15 CI job #44970

[WIP] Add a gcc 15 CI job #44970

jonkeane commented Dec 9, 2024 •

edited

Loading

jonkeane commented Dec 9, 2024

jonkeane commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

jonkeane commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

jonkeane commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

jonkeane commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

pitrou Dec 9, 2024

jonkeane Dec 9, 2024

jonkeane Dec 9, 2024

jonkeane commented Dec 10, 2024

github-actions bot commented Dec 10, 2024

jonkeane commented Dec 10, 2024

github-actions bot commented Dec 10, 2024

jonkeane commented Dec 10, 2024

github-actions bot commented Dec 10, 2024

jonkeane commented Dec 10, 2024

[WIP] Add a gcc 15 CI job #44970

[WIP] Add a gcc 15 CI job #44970

Conversation

jonkeane commented Dec 9, 2024 • edited Loading

jonkeane commented Dec 9, 2024

jonkeane commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

jonkeane commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

jonkeane commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

jonkeane commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

pitrou Dec 9, 2024

Choose a reason for hiding this comment

jonkeane Dec 9, 2024

Choose a reason for hiding this comment

jonkeane Dec 9, 2024

Choose a reason for hiding this comment

jonkeane commented Dec 10, 2024

github-actions bot commented Dec 10, 2024

jonkeane commented Dec 10, 2024

github-actions bot commented Dec 10, 2024

jonkeane commented Dec 10, 2024

github-actions bot commented Dec 10, 2024

jonkeane commented Dec 10, 2024

jonkeane commented Dec 9, 2024 •

edited

Loading