Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add a gcc 15 CI job #44970

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ci/docker/ubuntu-24.04-cpp.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,14 @@ RUN if [ "${gcc_version}" = "" ]; then \
add-apt-repository ppa:ubuntu-toolchain-r/volatile; \
fi; \
apt-get update -y -q && \
apt-get install -y -q --no-install-recommends \
if [ "${gcc_version}" == "snapshot" ]; then \
apt-get install -y -q --no-install-recommends \
gcc-${gcc_version} && \
else \
apt-get install -y -q --no-install-recommends \
g++-${gcc_version} \
gcc-${gcc_version} && \
fi; \
update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-${gcc_version} 100 && \
update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-${gcc_version} 100 && \
update-alternatives --install \
Expand Down
12 changes: 12 additions & 0 deletions dev/tasks/tasks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -962,6 +962,18 @@ tasks:
flags: -e CC=gcc-14 -e CXX=g++-14 -e RapidJSON_SOURCE=BUNDLED
image: ubuntu-cpp

test-ubuntu-24.04-cpp-gcc-15:
ci: github
template: docker-tests/github.linux.yml
params:
env:
CLANG_TOOLS: 15
GCC_VERSION: snapshot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm not sure what this is supposed to mean, but FTR we would only like to test against a released gcc version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to get a CI job up that tests what CRAN is testing at https://www.stats.ox.ac.uk/pub/bdr/gcc15/arrow.out Which, is indeed the unreleased GCC. I haven't (yet) gotten an email asking us to fix this, but we have in the past been asked to fix things that error on even unreleased compilers. (Yes, I know this sounds absurd, nevertheless it's the way CRAN works).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't need to even run it nightly (CRAN does that for us to an extent), but having something that lets us check and confirm if our fix worked would be lovely.

LLVM: 15
UBUNTU: 24.04
flags: -e CC=gcc-snapshot -e CXX=g++-snapshot -e RapidJSON_SOURCE=BUNDLED
image: ubuntu-cpp

test-skyhook-integration:
ci: github
template: docker-tests/github.linux.yml
Expand Down
Loading