-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-47646: [C++][FlightRPC] Follow Naming Convention #47658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
c65cb99
to
ef43ae9
Compare
ef43ae9
to
784149d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the Arrow Flight SQL ODBC codebase to follow consistent naming conventions across C++ files. Functions are renamed to PascalCase and variables to snake_case, with private/protected member variables using a trailing underscore suffix.
Key Changes:
- Functions converted from camelCase to PascalCase (e.g.,
isPrepared()
→IsPrepared()
) - Member variables converted to snake_case with trailing underscore (e.g.,
m_connection
→connection_
) - Parameter names converted to snake_case (e.g.,
connPropertyMap
→conn_property_map
)
Reviewed Changes
Copilot reviewed 75 out of 75 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
utils.cc/utils.h | Parameter name standardization for connection property map functions |
odbc_statement.cc/h | Function and member variable naming convention updates |
odbc_environment.cc/h | Member variables and methods renamed to follow conventions |
odbc_descriptor.cc/h | Comprehensive renaming of member variables and method signatures |
odbc_connection.cc/h | Function and member variable naming updates |
types.h | Struct member variables renamed to snake_case |
UI components | Window class member variables and method parameters updated |
Flight SQL components | Various member variables and method names standardized |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cpp/src/arrow/flight/sql/odbc/odbcabstraction/odbc_impl/odbc_descriptor.cc
Outdated
Show resolved
Hide resolved
cpp/src/arrow/flight/sql/odbc/odbcabstraction/odbc_impl/odbc_descriptor.cc
Outdated
Show resolved
Hide resolved
cpp/src/arrow/flight/sql/odbc/odbcabstraction/odbc_impl/odbc_descriptor.cc
Outdated
Show resolved
Hide resolved
...rc/arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/odbc_impl/odbc_descriptor.h
Outdated
Show resolved
Hide resolved
...rc/arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/odbc_impl/odbc_descriptor.h
Outdated
Show resolved
Hide resolved
784149d
to
543ee33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c925fbb. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
We want our code to adhere to Arrow's expected naming conventions.
What changes are included in this PR?
Functions are renamed to be
PascalCase
and variables are renamed to besnake_case
.Private/protected member variables are named
member_var_
.Public member variables are named
member_var
.Are these changes tested?
N/A
Are there any user-facing changes?
No.