Skip to content

Conversation

justing-bq
Copy link
Contributor

@justing-bq justing-bq commented Sep 25, 2025

Rationale for this change

We want our code to adhere to Arrow's expected naming conventions.

What changes are included in this PR?

Functions are renamed to be PascalCase and variables are renamed to be snake_case.
Private/protected member variables are named member_var_.
Public member variables are named member_var.

Are these changes tested?

N/A

Are there any user-facing changes?

No.

Copy link

⚠️ GitHub issue #47646 has been automatically assigned in GitHub to PR creator.

@justing-bq justing-bq changed the title GH-47646: [C++][FlightRPC] Fix Function & Variable Naming GH-47646: [C++][FlightRPC] Follow Naming Convention Sep 26, 2025
@justing-bq justing-bq marked this pull request as ready for review September 29, 2025 19:00
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Oct 1, 2025
@justing-bq justing-bq force-pushed the gh-47646-fix-naming branch from ef43ae9 to 784149d Compare October 1, 2025 16:47
@justing-bq
Copy link
Contributor Author

@lidavidm @kou
Could I get approval for my pending workflows? Thank you.

@kou kou requested a review from Copilot October 2, 2025 21:37
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the Arrow Flight SQL ODBC codebase to follow consistent naming conventions across C++ files. Functions are renamed to PascalCase and variables to snake_case, with private/protected member variables using a trailing underscore suffix.

Key Changes:

  • Functions converted from camelCase to PascalCase (e.g., isPrepared()IsPrepared())
  • Member variables converted to snake_case with trailing underscore (e.g., m_connectionconnection_)
  • Parameter names converted to snake_case (e.g., connPropertyMapconn_property_map)

Reviewed Changes

Copilot reviewed 75 out of 75 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
utils.cc/utils.h Parameter name standardization for connection property map functions
odbc_statement.cc/h Function and member variable naming convention updates
odbc_environment.cc/h Member variables and methods renamed to follow conventions
odbc_descriptor.cc/h Comprehensive renaming of member variables and method signatures
odbc_connection.cc/h Function and member variable naming updates
types.h Struct member variables renamed to snake_case
UI components Window class member variables and method parameters updated
Flight SQL components Various member variables and method names standardized

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@justing-bq justing-bq force-pushed the gh-47646-fix-naming branch from 784149d to 543ee33 Compare October 2, 2025 22:53
@justing-bq
Copy link
Contributor Author

@lidavidm @kou
I just addressed the copilot comments. Could I get another approval for the workflows?

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit c925fbb into apache:main Oct 3, 2025
39 checks passed
@kou kou removed the awaiting merge Awaiting merge label Oct 3, 2025
@justing-bq justing-bq deleted the gh-47646-fix-naming branch October 3, 2025 01:29
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c925fbb.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants