-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-47923: [CI] Use macos-15-intel instead of macos-13 for macOS x86 runner #47690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kevinjqliu for giving this a try!
dev/tasks/r/github.packages.yml
Outdated
| matrix: | ||
| platform: | ||
| - { runs_on: macos-13, arch: "x86_64" } | ||
| - { runs_on: macos-latest, arch: "arm64" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we still want to test with x86_64 architecture we probably should use the new macos-15-intel runners, see:
https://github.com/actions/runner-images?tab=readme-ov-file#available-images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes good catch! ty
a3e410b to
c61c40c
Compare
c61c40c to
a9ffb5b
Compare
|
@github-actions crossbow submit wheel-macos-monterey-*-amd64 verify-rc-source-macos |
|
Revision: a9ffb5b Submitted crossbow builds: ursacomputing/crossbow @ actions-9c62fc0d9f |
|
The macOS wheels seem to be failing due to mono being missing: We could try adding mono here, even though we probably want to fix it on the There are also some Python failures which I am unsure if they are related or they were fixed in the past. Could you rebase and I'll trigger again the |
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kevinjqliu for this. Will you have some time to follow up the CI failures? Otherwise I can try to take some time later on
|
|
a9ffb5b to
8990f06
Compare
8990f06 to
3c4b2a4
Compare
for the 2 failed "Verify RC / APIT" tests The C++ and Python failures are due to 1 failed test |
|
@github-actions crossbow submit verify-rc-source-python-macos-* |
|
@github-actions crossbow submit wheel-macos-monterey-cp310-cp310-amd64 |
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... They aren't failed on main: https://lists.apache.org/thread/svj4vv6ot6yj9b5qgydcjrbzps3g957z
- verify-rc-source-python-macos-amd64
https://github.com/ursacomputing/crossbow/actions/runs/18908687876/job/53973259662- verify-rc-source-python-macos-arm64
https://github.com/ursacomputing/crossbow/actions/runs/18908688967/job/53973263778
Could you rebase on main?
And could you update the PR description before we merge this? We'll use the PR description for commit message.
324171a to
6bdc0cf
Compare
|
rebased origin/main and updated the PR description |
|
|
|
@github-actions crossbow submit verify-rc-source-python-macos-* |
|
Revision: 6bdc0cf Submitted crossbow builds: ursacomputing/crossbow @ actions-e7168bd48b
|
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found what the problem is on those jobs and is unrelated to the changes. The problem is with the fork.
PyArrow is being generated with the wrong version (hence triggering some old behavior on pandas). See:
pyarrow-12.0.0.dev5006+g6bdc0cf07
This is because the fork is missing the tags for the newer Arrow releases and it's unable to generate the correct version.
This is related to:
I realized when I created a different PR to try and understand the failure. I decided to cherry-pick the exact same 4 commits that are on this PR on top of current main and my testing PR was able to run all the verification jobs successfully:
#48007
That's when I tried to understand what was the difference with the remote.
I am happy to merge this.
|
Ah, it make sense. @kevinjqliu Could you push tags in apache/arrow to your fork by |
6bdc0cf to
e274f39
Compare
|
pushed all the tags to my fork, rebased one more time for good measure. thanks! |
|
@github-actions crossbow submit verify-rc-source-python-macos-* |
|
Revision: e274f39 Submitted crossbow builds: ursacomputing/crossbow @ actions-5df507d974
|
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Passed. Let's merge this.
|
|
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 44f82a4. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
Rationale for this change
macos-13github runners are https://github.blog/changelog/2025-09-19-github-actions-macos-13-runner-image-is-closing-down/This PR replaces
macos-13withmacos-15-intelbased on recommendations hereWhat changes are included in this PR?
Change all references of
macos-13tomacos-15-intelAre these changes tested?
Yes, CI
Are there any user-facing changes?
No.