Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-767][DOC] Update the docs of celeborn.client.spark.push.sort.memory.threshold #1680

Closed
wants to merge 1 commit into from

Conversation

cfmcgrady
Copy link
Contributor

@cfmcgrady cfmcgrady commented Jul 5, 2023

What changes were proposed in this pull request?

As title

Why are the changes needed?

To clarify the usage of conf celeborn.client.spark.push.sort.memory.threshold

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GA

@cfmcgrady
Copy link
Contributor Author

@waitinfuture

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #1680 (4450b02) into main (5b3f43d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1680      +/-   ##
==========================================
+ Coverage   46.24%   46.26%   +0.02%     
==========================================
  Files         161      161              
  Lines        9957     9960       +3     
  Branches      920      920              
==========================================
+ Hits         4604     4607       +3     
  Misses       5050     5050              
  Partials      303      303              
Impacted Files Coverage Δ
...cala/org/apache/celeborn/common/CelebornConf.scala 87.16% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

waitinfuture pushed a commit that referenced this pull request Jul 5, 2023
…rt.memory.threshold`

### What changes were proposed in this pull request?

As title

### Why are the changes needed?

To clarify the usage of conf `celeborn.client.spark.push.sort.memory.threshold`

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Pass GA

Closes #1680 from cfmcgrady/docs.

Authored-by: Fu Chen <[email protected]>
Signed-off-by: zky.zhoukeyong <[email protected]>
(cherry picked from commit 3af5c23)
Signed-off-by: zky.zhoukeyong <[email protected]>
@cfmcgrady cfmcgrady deleted the docs branch July 5, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants