config: fix access for config and history file #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes apache#157 Signed-off-by: Abhishek Kumar <[email protected]>
rohityadavcloud
approved these changes
Aug 5, 2025
DaanHoogland
reviewed
Aug 5, 2025
Contributor
|
works as expected but I want to sugest being a touch more restrictive in the access rights, i.e. no group access. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes file access permissions for configuration and history files by setting them to group-private mode (0660). The changes ensure that sensitive configuration data is protected from unauthorized access by restricting permissions.
- Introduces a new
makeFileGroupPrivatefunction to set file permissions to 0660 - Applies permission fixes to both config and history files after they are saved
- Adds conditional permission setting for history files when they exist
Signed-off-by: Abhishek Kumar <[email protected]>
DaanHoogland
approved these changes
Aug 6, 2025
shwstppr
added a commit
to shwstppr/cloudstack-cloudmonkey
that referenced
this pull request
Aug 13, 2025
Fixes apache#157 --------- Signed-off-by: Abhishek Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157