Skip to content

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Aug 6, 2025

Adds a Github action to build binary for Linux x86-64 for easier testing of PRs. A comment will be added in the PR.
Workflow runs on pull_request_target and has two jobs - build, comment.
comment job needs issues:write permission due to which the workflow can run only when it is present on main.
build job only has read permission to prevent insecure permissions

Tested here: shwstppr#3

@shwstppr shwstppr marked this pull request as draft August 6, 2025 09:16
@shwstppr shwstppr marked this pull request as ready for review August 6, 2025 09:23
@shwstppr shwstppr force-pushed the builder branch 2 times, most recently from 09f1a9a to addb7e1 Compare August 6, 2025 09:43
@shwstppr shwstppr added this to the 6.5.0 milestone Aug 6, 2025
@shwstppr
Copy link
Contributor Author

shwstppr commented Aug 6, 2025

This needs whitelisting peter-evans/find-comment@v3 and peter-evans/create-or-update-comment@v4
If that can't be done I can try to modify workflow to not use them
cc @DaanHoogland @rohityadavcloud

@DaanHoogland
Copy link
Contributor

@shwstppr how about adding make dist and attach the contents of the dist dir to the pr? in that way arm/windows users will have binaries to test as well.

@shwstppr
Copy link
Contributor Author

shwstppr commented Aug 6, 2025

@shwstppr how about adding make dist and attach the contents of the dist dir to the pr? in that way arm/windows users will have binaries to test as well.

done

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@weizhouapache
Copy link
Member

@shwstppr
awesome !

the GHA run 3 times, is it intended ?
https://github.com/shwstppr/cloudstack-cloudmonkey/pull/3/checks

@shwstppr
Copy link
Contributor Author

shwstppr commented Aug 7, 2025

@weizhouapache I think that is some GHA discrepancy in general as it is also showing build (on: pull_request) runner multiple times too. I'll check though

@shwstppr shwstppr marked this pull request as draft August 8, 2025 07:10
Adds a Github action to build binary for Linux x86-64 for easier testing
of PRs. A comment will be added in the PR.

Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr
Copy link
Contributor Author

shwstppr commented Aug 8, 2025

Not working without community actions. Closing for now

@shwstppr shwstppr closed this Aug 8, 2025
@shwstppr
Copy link
Contributor Author

shwstppr commented Aug 8, 2025

Works on shwstppr#3 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants