-
Notifications
You must be signed in to change notification settings - Fork 71
github-action: add pr builder for easier testing #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
09f1a9a to
addb7e1
Compare
|
This needs whitelisting peter-evans/find-comment@v3 and peter-evans/create-or-update-comment@v4 |
|
@shwstppr how about adding |
done |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
@shwstppr the GHA run 3 times, is it intended ? |
|
@weizhouapache I think that is some GHA discrepancy in general as it is also showing build (on: pull_request) runner multiple times too. I'll check though |
Adds a Github action to build binary for Linux x86-64 for easier testing of PRs. A comment will be added in the PR. Signed-off-by: Abhishek Kumar <[email protected]>
|
Not working without community actions. Closing for now |
|
Works on shwstppr#3 now |
Adds a Github action to build binary for Linux x86-64 for easier testing of PRs. A comment will be added in the PR.
Workflow runs on
pull_request_targetand has two jobs - build, comment.commentjob needs issues:write permission due to which the workflow can run only when it is present on main.buildjob only has read permission to prevent insecure permissionsTested here: shwstppr#3