Outdated: Fix commit duplication in DynamicIcebergSink #14445
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
aiborodin
force-pushed
the
fix-duplicated-commit-in-iceberg-sinks
branch
3 times, most recently
from
fb6ef8e to
f2f1a59
Compare
Contributor
Author
|
@pvary Could you please take a look? |
aiborodin
force-pushed
the
fix-duplicated-commit-in-iceberg-sinks
branch
3 times, most recently
from
6d5ae0d to
65462d6
Compare
Change-Id: I3b97982e3dcc180bc82c36f97f335d873fbbde57
aiborodin
force-pushed
the
fix-duplicated-commit-in-iceberg-sinks
branch
from
65462d6 to
890a2d7
Compare
Contributor
Author
Contributor
Author
Contributor
Author
|
The new PR is raised. |
aiborodin
changed the title
aiborodin
changed the title
aiborodin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the race condition in #14425 by validating that all new parent snapshots, fetched by the table refresh in
SnapshotProducer.apply(), have a committed checkpoint id strictly lower than the checkpoint id of the currently staged committable. Abort the commit to prevent duplication otherwise.