Outdated: Fix commit duplication in DynamicIcebergSink (alternative) #14484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the commit duplication issue in the DynamicIcebergSink caused by a race condition during recovery from a failed commit to the REST catalog. Validate that no new parent snapshot fetched from a refresh operation in the SnapshotProducer has a committed checkpoint ID higher than or equal to the currently staged committable. Throw an exception if a duplicate snapshot is detected to let the Flink job retry and skip the new request. Add unit and integration tests to replicate the commit duplication. Change-Id: I92eca2987e4fbe9819ea9161dfe9e8b8bddb9105
This was referenced Nov 3, 2025
aiborodin
changed the title
Contributor
Author
|
The new PR is raised in #14517. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative solution to #14425, which uses the same idea of checking duplicate concurrent commits using snapshot validation, similar to #14445.
The current solution extends
BaseRowDeltaandBaseReplacePartitionsoperations in Flink packages instead of adding public API methods toRowDeltaandReplacePartitionsinterfaces in #14445.