[VL] Support uuid function #5014
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
| @@ -199,6 +199,10 @@ trait SparkPlanExecApi { | |||
| throw new UnsupportedOperationException("NaNvl is not supported") | |||
| } | |||
|
|
|||
| def genUuidTransformer(substraitExprName: String, original: Uuid): ExpressionTransformer = { | |||
| GenericExpressionTransformer(substraitExprName, Seq(), original) | |||
There was a problem hiding this comment.
Could you remind me why we distinguish the implementations of Velox and CH backend?
There was a problem hiding this comment.
Uuid is a leaf expression, looks CH just treat it as leaf expression and ignore the seed gerenated by spark.
Velox uuid can accept the seed parameter as a constant input. We get the seed and pass it to velox. This is the reason we distinguish the implements.
Thanks.
zhli1142015
force-pushed
the
uuid_support
branch
from
4968b83 to
cc78417
Compare
|
Run Gluten Clickhouse CI |
There was a problem hiding this comment.
@zhli1142015, just one comment. Please also rebase the code. Thanks!
backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala
Outdated
Show resolved
Hide resolved
zhli1142015
force-pushed
the
uuid_support
branch
from
cc78417 to
eeed575
Compare
|
Run Gluten Clickhouse CI |
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
Support uuid function.
How was this patch tested?
UT.