[KOGITO-7257] Documenting workflow metainfo #531
Conversation
fjtirado
requested review from
domhanak,
MarianMacik,
ricardozanini and
krisv
as code owners
|
@kaldesai can you take a look? |
serverlessworkflow/modules/ROOT/pages/core/understanding-jq-expressions.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/core/understanding-jq-expressions.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/core/understanding-jq-expressions.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/core/understanding-jq-expressions.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/core/understanding-jq-expressions.adoc
Outdated
Show resolved
Hide resolved
…pressions.adoc Co-authored-by: Kalyani Desai <[email protected]>
…pressions.adoc Co-authored-by: Kalyani Desai <[email protected]>
…pressions.adoc Co-authored-by: Kalyani Desai <[email protected]>
…pressions.adoc Co-authored-by: Kalyani Desai <[email protected]>
…pressions.adoc Co-authored-by: Kalyani Desai <[email protected]>
|
Thanks a lot @kaldesai |
| In addition to the predefined keys mentioned previously, you can add your own keys to workflow context using Java Service Loader mechanism, by providing an implementation of class link:{kogito_runtimes_url}/kogito-serverless-workflow/kogito-serverless-workflow-utils/src/main/java/org/kie/kogito/serverless/workflow/utils/KogitoProcessContextResolverExtension.java[KogitoProcessContextResolverExtension] | ||
|
|
||
| This feature was used to add quarkus security identity support, you can check source code as reference link:{kogito_runtimes_url}/quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow/src/main/java/org/kie/kogito/serverless/workflow/QuarkusKogitoProcessContextResolver.java[here]. | ||
|
|
There was a problem hiding this comment.
@domhanak based on your work to remove Quarkus citations throughout the doc sections, I think we should relocate this section Javi added. This is part of the "concepts" section, so we must not cite Quarkus here.
There was a problem hiding this comment.
@ricardozanini Since the quarkus mention is just an example of how to add a new context variable, I think the usage is legit here. The reason I mention the quarkus related implementation of KogitoProcessContextResolverExtension is because is straightforward and therefore suitable as example, but if an issue, I can change by a link to the one I used for python support
There was a problem hiding this comment.
I don't think we should mention Quarkus here. It's highly related to what we are trying to do. These concepts sections must be solely to working with workflows at the spec level and how our runtime handles it. We can move these paragraphs to a new section under Quarkus. This is a rich material that we must keep, it's just a matter of rearrangement. @domhanak wdyt?
There was a problem hiding this comment.
@ricardozanini Agreed, I am noting this and can work on rearranging. Just let me know the order we do this.
There was a problem hiding this comment.
I guess once we merge this, we can move in the PR you have opened #536
https://issues.redhat.com/browse/KOGITO-7257