-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KOGITO-7257] Documenting workflow metainfo #531
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f701d78
[KOGITO-7257] Documenting workflow metainfo
fjtirado 2a9f379
Update serverlessworkflow/modules/ROOT/pages/core/understanding-jq-ex…
fjtirado 0093c0f
Update serverlessworkflow/modules/ROOT/pages/core/understanding-jq-ex…
fjtirado db87f94
Update serverlessworkflow/modules/ROOT/pages/core/understanding-jq-ex…
fjtirado 13a0e71
Update serverlessworkflow/modules/ROOT/pages/core/understanding-jq-ex…
fjtirado 8ef4e81
Update serverlessworkflow/modules/ROOT/pages/core/understanding-jq-ex…
fjtirado File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@domhanak based on your work to remove Quarkus citations throughout the doc sections, I think we should relocate this section Javi added. This is part of the "concepts" section, so we must not cite Quarkus here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ricardozanini Since the quarkus mention is just an example of how to add a new context variable, I think the usage is legit here. The reason I mention the quarkus related implementation of KogitoProcessContextResolverExtension is because is straightforward and therefore suitable as example, but if an issue, I can change by a link to the one I used for python support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should mention Quarkus here. It's highly related to what we are trying to do. These concepts sections must be solely to working with workflows at the spec level and how our runtime handles it. We can move these paragraphs to a new section under Quarkus. This is a rich material that we must keep, it's just a matter of rearrangement. @domhanak wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ricardozanini Agreed, I am noting this and can work on rearranging. Just let me know the order we do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess once we merge this, we can move in the PR you have opened #536