Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing devservices timeout for keycloak #1991

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Aug 1, 2024

This should fix flaky test popping up

This should fix flaky test popping up
@@ -19,6 +19,7 @@

quarkus.http.port=8483
quarkus.native.native-image-xmx=8g
quarkus.devservices.timeout=2m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fjtirado
I see the point, but are we saying that this single test could hang two minutes before failing ?
Is it not a code-smell of some underlying issue ?
And if a similar problem arise on other tests, are we going to raise the timeout in the same way, getting to a never-ending build ?
My questions are not related to this PR in particular, for which I've not a strong opinion; but we are keeping increasing timeouts, lately, so maybe we should start looking at the issue at its root.
@baldimir any opinion on that ?

Copy link
Contributor Author

@fjtirado fjtirado Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitgabrio Jenkins is slow and downloading the keycloak image and deploying it takes more than the 60s default.
It has nothing to be with our codebase. See Apache list for more information on that. There I already complanined about our test strategy, but this one has to go in or the nightly is going to unnecesarily be flaky @pibizza

@fjtirado fjtirado requested review from pibizza and removed request for pibizza August 2, 2024 09:03
@fjtirado fjtirado merged commit a78de16 into apache:main Aug 2, 2024
4 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-examples that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants