Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increasing devservices timeout for keycloak #1991

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Increasing devservices timeout for keycloak #1991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...h2-orchestration-quarkus/acme-financial-service/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

quarkus.http.port=8483
quarkus.native.native-image-xmx=8g
quarkus.devservices.timeout=2m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fjtirado
I see the point, but are we saying that this single test could hang two minutes before failing ?
Is it not a code-smell of some underlying issue ?
And if a similar problem arise on other tests, are we going to raise the timeout in the same way, getting to a never-ending build ?
My questions are not related to this PR in particular, for which I've not a strong opinion; but we are keeping increasing timeouts, lately, so maybe we should start looking at the issue at its root.
@baldimir any opinion on that ?

Copy link
Contributor Author

@fjtirado fjtirado Aug 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitgabrio Jenkins is slow and downloading the keycloak image and deploying it takes more than the 60s default.
It has nothing to be with our codebase. See Apache list for more information on that. There I already complanined about our test strategy, but this one has to go in or the nightly is going to unnecesarily be flaky @pibizza


quarkus.swagger-ui.always-include=true

Expand Down
Loading