incubator-kie-issues#1483: Create a common Kie Flyway initializer for Kie Modules #3672
Conversation
...common/flyway/src/test/java/org/kie/flyway/H2KieFlywayKieFlywayMigrationInitializerTest.java
Outdated
Show resolved
Hide resolved
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3672 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3672/1/display/redirect Test results:
Those are the test failures: org.kie.kogito.integrationtests.quarkus.reactive.ProcessSvgAddonIT.testGetSvgProcessInstances1 expectation failed.Response body doesn't match expectation. Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]: Actual: EndStartProcessSecond Line Approval First Line Approval org.kie.kogito.integrationtests.quarkus.ProcessSvgAddonIT.testGetSvgProcessInstances1 expectation failed.Response body doesn't match expectation. Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]: Actual: EndStartProcessSecond Line Approval First Line Approval org.kie.kogito.svg.service.SpringBootProcessSvgServiceTest.annotateExecutedPathTestExpecting value to be false but was true org.kie.kogito.integrationtests.springboot.ProcessSvgAddonTest.testGetSvgProcessInstances1 expectation failed.Response body doesn't match expectation. Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]: Actual: EndStartProcessSecond Line Approval First Line Approval |
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3672 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3672/4/display/redirect Test results:
Those are the test failures: org.kie.kogito.integrationtests.quarkus.reactive.ProcessSvgAddonIT.testGetSvgProcessInstances1 expectation failed.Response body doesn't match expectation. Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]: Actual: EndStartProcessSecond Line Approval First Line Approval org.kie.kogito.integrationtests.quarkus.ProcessSvgAddonIT.testGetSvgProcessInstances1 expectation failed.Response body doesn't match expectation. Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]: Actual: EndStartProcessSecond Line Approval First Line Approval org.kie.kogito.svg.service.SpringBootProcessSvgServiceTest.annotateExecutedPathTestExpecting value to be false but was true org.kie.kogito.integrationtests.springboot.ProcessSvgAddonTest.testGetSvgProcessInstances1 expectation failed.Response body doesn't match expectation. Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]: Actual: EndStartProcessSecond Line Approval First Line Approval |
pefernan
changed the title
There was a problem hiding this comment.
Hi @pefernan
Thanks for the PR, but I think it is better to avoid framework-specific duplicated code.
Framework-specific classes should be just "proxy" to common code, with different annotations.
KieFlywaySpringbootInitializer code is exactly the same as KieFlywayRecorder.
Even if different frameworks may provide "utilities", in our context is better to have vanilla-java code, to reduce the hassle of maintaining two different implementations, since our code is a "library" meant to be used inside different applications, and not a "final downstream" project
|
Hi @pefernan |
|
@gitgabrio each module that requires initializing the DB (runtime-persistence, data-index, data-audit, jobs.. ) will have a |
|
Hi @gitgabrio this was disscussed already in the proper channels. Let's try to avoid noise in the PR. |
pefernan
force-pushed
the
incubator-kie-issues#1483
branch
from
9ca8a24
to
e7bbeed
Compare
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3672 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3672/5/display/redirect Test results:
Those are the test failures: org.kie.kogito.integrationtests.quarkus.reactive.ProcessSvgAddonIT.testGetSvgProcessInstances1 expectation failed.Response body doesn't match expectation. Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]: Actual: EndStartProcessSecond Line Approval First Line Approval org.kie.kogito.integrationtests.quarkus.ProcessSvgAddonIT.testGetSvgProcessInstances1 expectation failed.Response body doesn't match expectation. Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]: Actual: EndStartProcessSecond Line Approval First Line Approval org.kie.kogito.svg.service.SpringBootProcessSvgServiceTest.annotateExecutedPathTestExpecting value to be false but was true org.kie.kogito.integrationtests.springboot.ProcessSvgAddonTest.testGetSvgProcessInstances1 expectation failed.Response body doesn't match expectation. Expected: Expected namespace uri 'http://www.w3.org/2000/svg' but was 'null' - comparing at /svg[1]/defs[1] to at /svg[1]/defs[1]: Actual: EndStartProcessSecond Line Approval First Line Approval |
pefernan
force-pushed
the
incubator-kie-issues#1483
branch
from
e7bbeed
to
b23b949
Compare
.../common/flyway/src/test/java/org/kie/flyway/impl/DefaultKieModuleFlywayConfigLoaderTest.java
Outdated
Show resolved
Hide resolved
- README.md
There was a problem hiding this comment.
Added some minor remarks regarding the readme
Great job @pefernan
quarkus/addons/flyway/runtime/src/main/java/org/kie/flyway/quarkus/KieFlywayRecorder.java
Outdated
Show resolved
Hide resolved
- Api improvements
pefernan
force-pushed
the
incubator-kie-issues#1483
branch
from
c868a3a
to
21909a2
Compare
addons/common/flyway/src/main/java/org/kie/flyway/initializer/KieFlywayInitializer.java
Outdated
Show resolved
Hide resolved
...kus/addons/flyway/runtime/src/main/java/org/kie/flyway/quarkus/KieFlywayQuarkusRecorder.java
Outdated
Show resolved
Hide resolved
.../deployment/src/main/java/org/kie/flyway/quarkus/deployment/KieFlywayExtensionProcessor.java
Outdated
Show resolved
Hide resolved
|
good catch @gitgabrio |
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3672 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3672/10/display/redirect Test results:
Those are the test failures: |
… Kie Modules (apache#3672) * incubator-kie-issues#1483: Create a common Kie Flyway initializer for Kie Modules * - cleanup * - cleanup * - ddls * - runtime configuration changes * - changing script locations * - Improved testing - README.md * - README.md - Api improvements * - minor changes
Closes apache/incubator-kie-issues#1483
Ensemble:
#3672
apache/incubator-kie-kogito-apps#2102
apache/incubator-kie-kogito-examples#2014
Many thanks for submitting your Pull Request ❤️!
Closes/Fixes/Resolves #ISSUE-NUMBER
Description:
Please make sure that your PR meets the following requirements:
Issue-XYZ Subject[0.9.x] Issue-XYZ SubjectHow to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.