Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incubator-kie-issues#1483: Create a common Kie Flyway initializer for Kie Modules #542

Closed
wants to merge 3 commits into from

Conversation

pefernan
Copy link

@pefernan pefernan commented Sep 25, 2024

Closed for now

Description of the change:

Motivation for the change:

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pefernan, is the idea of changing the env name?

@rhkp, can you also take a look?

@pefernan
Copy link
Author

@ricardozanini yes, the reason is that I changed the Flyway initialization of the data-index / jobs-service images. But I'm considering rolling back this change for the images. I don't want to cause any backguard incompatibility in images and operator. Tomorrow I'll try to leave the images as they were and luckily I could close this PR, leaving the operator as it is.

If we want to apply this change later, we'll have time to do it in a nother task.

@pefernan
Copy link
Author

@ricardozanini let's catch up tomorrow about this.

@pefernan
Copy link
Author

pefernan commented Sep 27, 2024

@ricardozanini Rolled back the changes in the Data Index / Jobs Service images, so it will keep using the same Flyway setup. No need to change here

@pefernan pefernan closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants