KOGITO-8276: Improve the logging adding missing levels

[manstis]

Description of the change:

See https://issues.redhat.com/browse/KOGITO-8276

Motivation for the change:

Consolidate logging system.

Checklist

• Add or Modify a unit test for your change
• Have you verified that all the tests are passing?

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

[manstis]

@ricardozanini I'm going to need some advice here.

I had to remove klog.InitFlags(nil) from the Logger wrappers as go was panicing that a flag was being redefined.

I originally added it to ensure the v flag from the CLI was going to be detected; but it seems something somewhere is already parsing the CLI flags... To be honest the CLI argument binding mechanism in go is like black-magic to me. What should I do? Leave the initialisation in my wrappers out? Is there a different way I should have done it?

[ricardozanini]

I had to remove klog.InitFlags(nil) from the Logger wrappers as go was panicing that a flag was being redefined.

That's perfectly fine. klog should be reading the go flags under the hood by the controller-runtime or apimachinanery structs. We can leave it this way since we won't override the flag for something else but follow k8s conventions. 👍

[ricardozanini]

Nice work, many thanks! 🙏

A few minor comments. One thing that we could add to the manager deployment file, is the:

args:
  - '-v=1'

So, by default, we set the verbosity to WARN and give a clue to the administrator to fine-tune their setup.

[manstis]

Hmmmm.. both failing set of tests seem to relate to both stdout and stderr being None.

2023-07-28 08:00:08,324 tools.py:366        ERROR Command '['/usr/bin/podman', 'build', '--squash', '-t', 'kogito-serverless-operator:2.0.0-snapshot', '-t', 'kogito-serverless-operator:latest', 'target/image']' returned non-zero exit status 125. Command stdout is 'None' with stderr 'None'

2023-07-28 07:56:21,295 tools.py:375        ERROR Command '['/usr/bin/podman', 'build', '--squash', '-t', 'kogito-serverless-operator:2.0.0-snapshot', '-t', 'kogito-serverless-operator:latest', 'target/image']' returned non-zero exit status 1. Command stdout is 'None' with stderr 'None'

[spolti]

very nice, just a few comments, not mandatory.

[manstis]

Hi @desmax74 this is just waiting for your final approval.

[desmax74]

@manstis added the request to remove the ":" where was the placeholder.