NO-ISSUE: Fix JBPM DevUI Quarkus HTTP Host and Port #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pefernan
approved these changes
Sep 3, 2024
fantonangeli
reviewed
Sep 3, 2024
| @@ -9,11 +9,11 @@ quarkus.kogito.data-index.graphql.ui.always-include=true | |||
| quarkus.http.test-port=0 | |||
|
|
|||
| # Kogito-service | |||
| kogito.service.url=http://localhost:8080 | |||
| kogito.service.url=http://0.0.0.0:8080 | |||
There was a problem hiding this comment.
@thiagoelg @pefernan Should I apply this change to:
examples/sonataflow-greeting-quarkus-example/src/main/resources/application.properties
in this PR: #2511 ?
There was a problem hiding this comment.
Maybe... we switched from localhost because localhost could have different meanings in different contexts (in a container, for example).
And our solution to run quarkus apps in dev mode on OpenShift was to replace quarkus.http.host:quarkus.http.port with window.location.origin basically.
tiagobento
approved these changes
Sep 3, 2024
ljmotta
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.0.0.0instead oflocalhostfor Quarkus Apps to support running dev mode on containers;quarkus.http.hostandquarkus.http.port.