Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: Fix JBPM DevUI Quarkus HTTP Host and Port #2552

Merged
merged 4 commits into from
Sep 3, 2024
Merged

NO-ISSUE: Fix JBPM DevUI Quarkus HTTP Host and Port #2552

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8aa8de2
NO-ISSUE: Fix JBPM DevUI Quarkus HTTP Host and Port
thiagoelg Sep 2, 2024
d6d31e3
orElse
thiagoelg Sep 2, 2024
dfe87e2
Remove debug code
thiagoelg Sep 2, 2024
16a0815
Revert properties
thiagoelg Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions examples/jbpm-compact-architecture-example/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ quarkus.kogito.data-index.graphql.ui.always-include=true
quarkus.http.test-port=0

# Kogito-service
kogito.service.url=http://localhost:8080
kogito.service.url=http://0.0.0.0:8080
Copy link
Contributor

@fantonangeli fantonangeli Sep 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thiagoelg @pefernan Should I apply this change to:
examples/sonataflow-greeting-quarkus-example/src/main/resources/application.properties
in this PR: #2511 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe... we switched from localhost because localhost could have different meanings in different contexts (in a container, for example).

And our solution to run quarkus apps in dev mode on OpenShift was to replace quarkus.http.host:quarkus.http.port with window.location.origin basically.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @thiagoelg


#Job-service
kogito.jobs-service.url=http://localhost:8080
kogito.dataindex.http.url=http://localhost:8080
kogito.jobs-service.url=http://0.0.0.0:8080
kogito.dataindex.http.url=http://0.0.0.0:8080

# run create tables scripts
quarkus.flyway.migrate-at-start=true
Expand All @@ -26,8 +26,8 @@ kogito.persistence.type=jdbc
quarkus.datasource.db-kind=postgresql
%prod.quarkus.datasource.username=kogito-user
%prod.quarkus.datasource.password=kogito-pass
%prod.quarkus.datasource.jdbc.url=${QUARKUS_DATASOURCE_JDBC_URL:jdbc:postgresql://localhost:5432/kogito}
%prod.quarkus.datasource.reactive.url=${QUARKUS_DATASOURCE_REACTIVE_URL:postgresql://localhost:5432/kogito}
%prod.quarkus.datasource.jdbc.url=${QUARKUS_DATASOURCE_JDBC_URL:jdbc:postgresql://0.0.0.0:5432/kogito}
%prod.quarkus.datasource.reactive.url=${QUARKUS_DATASOURCE_REACTIVE_URL:postgresql://0.0.0.0:5432/kogito}

quarkus.native.native-image-xmx=8g

Expand Down
5 changes: 2 additions & 3 deletions ...devui-deployment/src/main/java/org/jbpm/quarkus/devui/deployment/DevConsoleProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,8 @@ public CardPageBuildItem pages(

String devUIUrl = getProperty(configurationBuildItem, systemPropertyBuildItems, "kogito.dev-ui.url");
String dataIndexUrl = getProperty(configurationBuildItem, systemPropertyBuildItems, "kogito.dataindex.http.url");
String trustyServiceUrl = getProperty(configurationBuildItem, systemPropertyBuildItems, "kogito.trusty.http.url");
String quarkusHttpHost = ConfigProvider.getConfig().getValue("quarkus.http.host", String.class);
String quarkusHttpPort = ConfigProvider.getConfig().getValue("quarkus.http.port", String.class);
String quarkusHttpHost = ConfigProvider.getConfig().getOptionalValue("quarkus.http.host", String.class).orElse("0.0.0.0");
String quarkusHttpPort = ConfigProvider.getConfig().getOptionalValue("quarkus.http.port", String.class).orElse("8080");

CardPageBuildItem cardPageBuildItem = new CardPageBuildItem();

Expand Down
Loading