kie-issues#2466: Serverless Logic Web Tools: Runtime Tools settings doesn't validate the data index url. #2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fantonangeli Please review this PR. Thank you. |
fantonangeli
requested changes
Sep 20, 2024
packages/serverless-logic-web-tools/src/settings/runtimeTools/RuntimeToolsSettings.tsx
Outdated
Show resolved
Hide resolved
packages/serverless-logic-web-tools/src/settings/runtimeTools/RuntimeToolsSettings.tsx
Outdated
Show resolved
Hide resolved
packages/serverless-logic-web-tools/tests/url/dataIndexValidUrl.test.ts
Outdated
Show resolved
Hide resolved
packages/serverless-logic-web-tools/tests/url/dataIndexValidUrl.test.ts
Outdated
Show resolved
Hide resolved
packages/serverless-logic-web-tools/src/settings/runtimeTools/RuntimeToolsSettings.tsx
Show resolved
Hide resolved
fantonangeli
requested changes
Sep 23, 2024
packages/serverless-logic-web-tools/src/settings/runtimeTools/RuntimeToolsSettings.tsx
Outdated
Show resolved
Hide resolved
fantonangeli
approved these changes
Sep 23, 2024
thiagoelg
approved these changes
Oct 8, 2024
|
There are multiple failures after merging this to |
|
Thanks @tiagobento, I'm checking now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes apache/incubator/kie-issues#2466
Description:
The data index url is now validated and if its invalid an alert is shown.
How to test:
serverless-logic-web-toolspackagepnpm startPreview:
Screen.Recording.2024-09-20.at.4.21.45.PM.mov