kie-issues#2466: Serverless Logic Web Tools: Runtime Tools settings doesn't validate the data index url.

packages/runtime-tools-swf-gateway-api/src/gatewayApi/apis.tsx

@@ -729,3 +729,22 @@ export const saveFormContent = (formName: string, content: FormContent): Promise
       .catch((error) => reject(error));
   });
 };
+
+export async function verifyDataIndex(dataIndexUrl?: string): Promise<boolean> {
+  if (!dataIndexUrl) {
+    return false;
+  }
+
+  try {
+    const response = await fetch(dataIndexUrl, {
+      headers: {
+        "Content-Type": "application/json",
+      },
+      method: "POST",
+      body: '{"query":""}',
+    });
+    return response.status === 200;
+  } catch (e) {
+    return false;
+  }
+}

packages/serverless-logic-web-tools/src/i18n/AppI18n.ts

@@ -71,7 +71,6 @@ interface AppDictionary extends ReferenceDictionary {
       validationError: string;
       connectionError: string;
       configExpiredWarning: string;
-      validDataIndexURLError: string;
     };
     confirmModal: {
       title: string;
@@ -106,6 +105,12 @@ interface AppDictionary extends ReferenceDictionary {
       dependencyWarningTooltip: string;
     };
   };
+  RuntimeToolsSettings: {
+    configModal: {
+      validDataIndexURLError: string;
+      dataIndexConnectionError: string;
+    };
+  };
 }
 
 export interface AppI18n extends AppDictionary, CommonI18n {}

packages/serverless-logic-web-tools/src/i18n/locales/de.ts

@@ -73,7 +73,6 @@ export const de: AppI18n = {
       validationError: "Sie müssen alle erforderlichen Felder ausfüllen, bevor Sie fortfahren können.",
       connectionError: "Verbindung abgelehnt. Bitte überprüfen Sie die angegebenen Informationen.",
       configExpiredWarning: "Token oder Konto ist abgelaufen. Bitte aktualisieren Sie Ihre Konfiguration.",
-      validDataIndexURLError: "Bitte geben Sie eine gültige Datenindex-URL ein.",
     },
     confirmModal: {
       title: "Bereitstellen",
@@ -113,4 +112,10 @@ export const de: AppI18n = {
         "Modelle in diesem Arbeitsbereich können von Bereitstellungen aus anderen Arbeitsbereichen abhängen.",
     },
   },
+  RuntimeToolsSettings: {
+    configModal: {
+      validDataIndexURLError: "Bitte geben Sie eine gültige Datenindex-URL ein.",
+      dataIndexConnectionError: "Verbindung abgelehnt. Bitte überprüfen Sie die bereitgestellten Informationen.",
+    },
+  },
 };

packages/serverless-logic-web-tools/src/i18n/locales/en.ts

@@ -71,7 +71,6 @@ export const en: AppI18n = {
       validationError: "You must fill out all required fields before you can proceed.",
       connectionError: "Connection refused. Please check the information provided.",
       configExpiredWarning: "Token or account expired. Please update your configuration.",
-      validDataIndexURLError: "Please enter a valid Data Index URL.",
     },
     confirmModal: {
       title: "Deploy",
@@ -109,4 +108,10 @@ export const en: AppI18n = {
       dependencyWarningTooltip: "Models in this workspace may depend on deployments from other workspaces.",
     },
   },
+  RuntimeToolsSettings: {
+    configModal: {
+      validDataIndexURLError: "Please enter a valid Data Index URL.",
+      dataIndexConnectionError: "Connection refused. Please check the information provided.",
+    },
+  },
 };

packages/serverless-logic-web-tools/src/settings/runtimeTools/RuntimeToolsSettings.tsx

@@ -43,15 +43,17 @@ import {
   saveConfigCookie,
 } from "./RuntimeToolsConfig";
 import { removeTrailingSlashFromUrl } from "../../url";
-import { validDataIndexUrl } from "../../url";
+import { isDataIndexUrlValid } from "../../url";
 import { Alert } from "@patternfly/react-core/dist/js";
 import { useAppI18n } from "../../i18n";
+import { verifyDataIndex } from "@kie-tools/runtime-tools-swf-gateway-api/src/gatewayApi/apis";
 
 const PAGE_TITLE = "Runtime Tools";
 
-enum DataIndexValidation {
+enum FormValiationOptions {
   INITIAL = "INITIAL",
   INVALID = "INVALID",
+  CONNECTION_ERROR = "CONNECTION_ERROR",
 }
 
 export function RuntimeToolsSettings(props: SettingsPageProps) {
@@ -60,10 +62,12 @@ export function RuntimeToolsSettings(props: SettingsPageProps) {
   const settingsDispatch = useSettingsDispatch();
   const [config, setConfig] = useState(settings.runtimeTools.config);
   const [isModalOpen, setIsModalOpen] = useState(false);
-  const [isDataIndexUrlValidated, setDataIndexUrlValidated] = useState(DataIndexValidation.INVALID);
+  const [isDataIndexUrlValidated, setDataIndexUrlValidated] = useState(FormValiationOptions.INITIAL);
+  const [isDataIndexUrlVerified, setisDataIndexUrlVerified] = useState(FormValiationOptions.INITIAL);
+  const [dataIndexUrlAvailable, setDataIndexUrlAvailable] = useState<boolean>(false);
 
   useEffect(() => {
-    setDataIndexUrlValidated(DataIndexValidation.INITIAL);
+    setDataIndexUrlValidated(FormValiationOptions.INITIAL);
   }, [config]);
 
   const handleModalToggle = useCallback(() => {
@@ -90,13 +94,21 @@ export function RuntimeToolsSettings(props: SettingsPageProps) {
     resetConfigCookie();
   }, [settingsDispatch.runtimeTools]);
 
-  const onApply = useCallback(() => {
+  const onApply = useCallback(async () => {
     const newConfig: RuntimeToolsSettingsConfig = {
       dataIndexUrl: removeTrailingSlashFromUrl(config.dataIndexUrl),
     };
-    if (!validDataIndexUrl(config.dataIndexUrl)) {
-      setDataIndexUrlValidated(DataIndexValidation.INVALID);
+    const isDataIndexUrlVerified = await verifyDataIndex(config.dataIndexUrl);
+    if (!isDataIndexUrlValid(config.dataIndexUrl)) {
+      setDataIndexUrlValidated(FormValiationOptions.INVALID);
       return;
+    } else {
+      if (isDataIndexUrlVerified == true) {
+        setDataIndexUrlAvailable(true);
+      } else {
+        setisDataIndexUrlVerified(FormValiationOptions.CONNECTION_ERROR);
+        return;
+      }
     }
 
     setConfig(newConfig);
@@ -163,17 +175,28 @@ export function RuntimeToolsSettings(props: SettingsPageProps) {
           appendTo={props.pageContainerRef.current || document.body}
         >
           <Form>
-            {isDataIndexUrlValidated === DataIndexValidation.INVALID && (
+            {isDataIndexUrlValidated === FormValiationOptions.INVALID && (
               <FormAlert>
                 <Alert
                   variant="danger"
-                  title={i18n.openshift.configModal.validDataIndexURLError}
+                  title={i18n.RuntimeToolsSettings.configModal.validDataIndexURLError}
                   aria-live="polite"
                   isInline
                   data-testid="alert-data-index-url-invalid"
                 />
               </FormAlert>
             )}
+            {isDataIndexUrlVerified === FormValiationOptions.CONNECTION_ERROR && (
+              <FormAlert>
+                <Alert
+                  variant="danger"
+                  title={i18n.RuntimeToolsSettings.configModal.dataIndexConnectionError}
+                  aria-live="polite"
+                  isInline
+                  data-testid="alert-data-index-url-connection-error"
+                />
+              </FormAlert>
+            )}
             <FormGroup
               label={"Data Index URL"}
               labelIcon={

packages/serverless-logic-web-tools/src/url/index.ts

@@ -27,10 +27,10 @@ export function removeTrailingSlashFromUrl(url: string): string {
   return url.replace(/\/$/, "");
 }
 
-export function validDataIndexUrl(url: string): boolean {
+export function isDataIndexUrlValid(url: string): boolean {
   try {
-    new URL(url);
-    return true;
+    const parsedUrl = new URL(url);
+    return parsedUrl.protocol === "http:" || parsedUrl.protocol === "https:";
   } catch (_) {
     return false;
   }

packages/serverless-logic-web-tools/tests/url/dataIndexValidUrl.test.ts

@@ -17,15 +17,15 @@
  * under the License.
  */
 
-import { validDataIndexUrl } from "../../src/url";
+import { isDataIndexUrlValid } from "../../src/url";
 
-describe("removeTrailingSlash", () => {
+describe("isDataIndexUrlValid", () => {
   it.each([
+    ["http://example.com", true],
     ["http://example.com/", true],
     ["https://example.com/", true],
-    ["loremIpsum", false],
-    ["google.com", false],
-  ])("should validate the data index URL", (inputUrl, isValidUrl) => {
-    expect(validDataIndexUrl(inputUrl)).toBe(isValidUrl);
+    ["ftps://example.com/", false],
+  ])("the data index URL %s validation should be %s", (inputUrl, isValidUrl) => {
+    expect(isDataIndexUrlValid(inputUrl)).toBe(isValidUrl);
   });
 });

packages/sonataflow-deployment-webapp/src/context/AppContextProvider.tsx

@@ -19,9 +19,10 @@
 
 import React, { PropsWithChildren, useEffect, useMemo, useState } from "react";
 import { DEFAULT_APPDATA_VALUES } from "../AppConstants";
-import { AppData, verifyDataIndex } from "../data";
+import { AppData } from "../data";
 import { useAppDataPromise } from "../hooks/useAppDataPromise";
 import { AppContext } from "./AppContext";
+import { verifyDataIndex } from "@kie-tools/runtime-tools-swf-gateway-api/src/gatewayApi/apis";
 
 export function AppContextProvider(props: PropsWithChildren<{}>) {
   const appDataPromise = useAppDataPromise();

packages/sonataflow-deployment-webapp/src/data/index.ts

@@ -29,22 +29,3 @@ export async function fetchAppData(): Promise<AppData> {
   const response = await fetch(routes.dataJson.path({}));
   return (await response.json()) as AppData;
 }
-
-export async function verifyDataIndex(dataIndexUrl?: string): Promise<boolean> {
-  if (!dataIndexUrl) {
-    return false;
-  }
-
-  try {
-    const response = await fetch(dataIndexUrl, {
-      headers: {
-        "Content-Type": "application/json",
-      },
-      method: "POST",
-      body: '{"query":""}',
-    });
-    return response.status === 200;
-  } catch (e) {
-    return false;
-  }
-}