Skip to content

Commit

Permalink
[KYUUBI #5779] [CI] Upgrade Github actions for Docker
Browse files Browse the repository at this point in the history
# 🔍 Description
## Issue References 🔗

As described.

## Describe Your Solution 🔧

- Bump docker/setup-buildx-action from v2 to v3
  -  docker/setup-buildx-action v3.0.0 release note: https://github.com/docker/setup-buildx-action/releases/tag/v3.0.0
- Bump docker/build-push-action from v3 to v5
  - docker/buld-push action v5.1.0 release note: https://github.com/docker/build-push-action/releases/tag/v5.1.0
- Bump docker/login-action from v2 to v3
  - v3.0.0 release note: https://github.com/docker/login-action/releases/tag/v3.0.0
- Bump setup-qemu-action from v2 to v3
  - v3.0.0 release note: https://github.com/docker/setup-qemu-action/releases/tag/v3.0.0
- All upgraded actions now use NodeJS 20 as default runtime

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️
No behavior changes.

#### Behavior With This Pull Request 🎉
No behavior changes.

#### Related Unit Tests
No behavior changes.

---

# Checklists
## 📝 Author Self Checklist

- [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [x] I have performed a self-review
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

## 📝 Committer Pre-Merge Checklist

- [ ] Pull request title is okay.
- [ ] No license issues.
- [ ] Milestone correctly set?
- [ ] Test coverage is ok
- [ ] Assignees are selected.
- [ ] Minimum number of approvals
- [ ] No changes are requested

**Be nice. Be informative.**

Closes #5779 from bowenliang123/docker-push-v5.

Closes #5779

ceed9e0 [Bowen Liang] bump docker/setup-qemu-action to v3
810bc18 [Bowen Liang] bump
ad36ebc [Bowen Liang] Bump docker/build-push-action from v3 to v5

Authored-by: Bowen Liang <[email protected]>
Signed-off-by: liangbowen <[email protected]>
  • Loading branch information
bowenliang123 committed Nov 27, 2023
1 parent 67bf8e1 commit c8b4dd1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -398,9 +398,9 @@ jobs:
uses: actions/checkout@v4
# https://github.com/docker/build-push-action
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3
- name: Build Kyuubi Docker Image
uses: docker/build-push-action@v3
uses: docker/build-push-action@v5
with:
# passthrough CI into build container
build-args: |
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/publish-snapshot-docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,16 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
- name: Set up QEMU
uses: docker/setup-qemu-action@v2
uses: docker/setup-qemu-action@v3
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3
- name: Login to Docker Hub
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USER }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
- name: Build and Push Kyuubi Docker Image
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
# build cache on Github Actions, See: https://docs.docker.com/build/cache/backends/gha/#using-dockerbuild-push-action
cache-from: type=gha
Expand Down

0 comments on commit c8b4dd1

Please sign in to comment.