-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Use new Apache 'closer.lua' syntax for kyuubi-download to obtain engine archives #4279
Comments
Hey @yaooqinn, I am willing to work upon this issue, could you please help me to understand this issue and the required technologies for the same |
Hi @yash-gupta167, you can refer to the closer.lua 's doc https://infra.apache.org/release-download-pages.html#closer |
Thank you for providing this information. It seems like the closer.lua redirector has a new syntax that is causing issues with the kyuubi-download module. To use the new syntax, you need to alter your download page to point to closer.lua and pass in the relative path to the artifact as a parameter. For example, if your artifact is located at http://www.apache.org/dyn/closer.lua/bar/foo/foo-5.5.1.zip Alternatively, you can generate a direct download link using the following syntax: http://www.apache.org/dyn/closer.lua/bar/foo/foo-5.5.1.zip?action=download Please Let me know, if I am going correct and please do provide further procedure! |
Using a direct download link looks good to me |
The direct link site an error:
What shall I do Further, Please guide me through it. |
please show us the link? |
bar & foo are dummy, can you use the existing projects, which are also what we need? |
@yaooqinn ,I understand, just need to modify the pom.xml of the Kyuubi-download module, right? The example code is as follows :
|
Thank you @sincewhen. You are probably right, but I'm not sure whether the Google Downloader maven plugin supports this feature. |
…wnload to obtain engine …ne archives # 🔍 Description ## Issue References [4279](https://github.com/apache/kyuubi/issues/4279)🔗 This pull request fixes # ## Describe Your Solution 🔧 Use new Apache 'closer.lua' syntax for kyuubi-download to obtain engine ## Types of changes 🔖 - [x] New feature (non-breaking change which adds functionality) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6009 from sincewhen/master. Closes apache#4279 2152a9b [yuqingyang] Use new Apache 'closer.lua' syntax for kyuubi-download to obtain engine archives Authored-by: yuqingyang <[email protected]> Signed-off-by: Kent Yao <[email protected]>
…download to obtain engine" This reverts commit 47a1091.
…wnload to obtain engine …ne archives # 🔍 Description ## Issue References [4279](https://github.com/apache/kyuubi/issues/4279)🔗 This pull request fixes # ## Describe Your Solution 🔧 Use new Apache 'closer.lua' syntax for kyuubi-download to obtain engine ## Types of changes 🔖 - [x] New feature (non-breaking change which adds functionality) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6009 from sincewhen/master. Closes apache#4279 2152a9b [yuqingyang] Use new Apache 'closer.lua' syntax for kyuubi-download to obtain engine archives Authored-by: yuqingyang <[email protected]> Signed-off-by: Kent Yao <[email protected]>
…yuubi-download to obtain engine" This reverts commit 47a1091.
Code of Conduct
Search before asking
What would you like to be improved?
The current closer.lua redirector, which redirects to download spark/flink etc, from a local mirror, has a new syntax. kyuubi-download module does not work properly with it currently.
How should we improve?
No response
Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: