Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Use new Apache 'closer.lua' syntax for kyuubi-download to obtain engine archives #4279

Closed
2 of 4 tasks
yaooqinn opened this issue Feb 9, 2023 · 10 comments
Closed
2 of 4 tasks

Comments

@yaooqinn
Copy link
Member

yaooqinn commented Feb 9, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

The current closer.lua redirector, which redirects to download spark/flink etc, from a local mirror, has a new syntax. kyuubi-download module does not work properly with it currently.

How should we improve?

No response

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@yash-gupta167
Copy link

Hey @yaooqinn, I am willing to work upon this issue, could you please help me to understand this issue and the required technologies for the same

@yaooqinn
Copy link
Member Author

Hi @yash-gupta167, you can refer to the closer.lua 's doc https://infra.apache.org/release-download-pages.html#closer

@yash-gupta167
Copy link

Thank you for providing this information. It seems like the closer.lua redirector has a new syntax that is causing issues with the kyuubi-download module. To use the new syntax, you need to alter your download page to point to closer.lua and pass in the relative path to the artifact as a parameter.

For example, if your artifact is located at bar/foo/foo-5.5.1.zip relative to downloads.apache.org, then the download link would be:

http://www.apache.org/dyn/closer.lua/bar/foo/foo-5.5.1.zip

Alternatively, you can generate a direct download link using the following syntax:

http://www.apache.org/dyn/closer.lua/bar/foo/foo-5.5.1.zip?action=download

Please Let me know, if I am going correct and please do provide further procedure!

@yaooqinn
Copy link
Member Author

Using a direct download link looks good to me

@yash-gupta167
Copy link

The direct link site an error:

The requested file does not exist in our mirror system or in our archives.

What shall I do Further, Please guide me through it.

@yaooqinn
Copy link
Member Author

please show us the link?

@yash-gupta167
Copy link

@yaooqinn
Copy link
Member Author

yaooqinn commented Feb 21, 2023

bar & foo are dummy, can you use the existing projects, which are also what we need?

@sincewhen
Copy link

@yaooqinn ,I understand, just need to modify the pom.xml of the Kyuubi-download module, right? The example code is as follows :

<execution>
    <id>download-flink-release</id>
        <goals>
		<goal>curl</goal>
        </goals>
        <phase>compile</phase>
    <configuration>
	<skip>${flink.archive.download.skip}</skip>
        <url>***.zip?action=download)</url>
    </configuration>
</execution>

@yaooqinn
Copy link
Member Author

Thank you @sincewhen.

You are probably right, but I'm not sure whether the Google Downloader maven plugin supports this feature.

zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this issue Feb 5, 2024
…wnload to obtain engine

…ne archives

# 🔍 Description
## Issue References [4279](https://github.com/apache/kyuubi/issues/4279)🔗

This pull request fixes #

## Describe Your Solution 🔧

Use new Apache 'closer.lua' syntax for kyuubi-download to obtain engine

## Types of changes 🔖

- [x] New feature (non-breaking change which adds functionality)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6009 from sincewhen/master.

Closes apache#4279

2152a9b [yuqingyang] Use new Apache 'closer.lua' syntax for kyuubi-download to obtain engine archives

Authored-by: yuqingyang <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
pan3793 added a commit that referenced this issue Mar 6, 2024
…download to obtain engine"

This reverts commit 47a1091.
zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this issue Mar 21, 2024
…wnload to obtain engine

…ne archives

# 🔍 Description
## Issue References [4279](https://github.com/apache/kyuubi/issues/4279)🔗

This pull request fixes #

## Describe Your Solution 🔧

Use new Apache 'closer.lua' syntax for kyuubi-download to obtain engine

## Types of changes 🔖

- [x] New feature (non-breaking change which adds functionality)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6009 from sincewhen/master.

Closes apache#4279

2152a9b [yuqingyang] Use new Apache 'closer.lua' syntax for kyuubi-download to obtain engine archives

Authored-by: yuqingyang <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this issue Mar 21, 2024
…yuubi-download to obtain engine"

This reverts commit 47a1091.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants