[KYUUBI #4279] Use new Apache 'closer.lua' syntax for kyuubi-download to obtain engine

[sincewhen]

…ne archives

🔍 Description

Issue References 4279🔗

This pull request fixes #

Describe Your Solution 🔧

Use new Apache 'closer.lua' syntax for kyuubi-download to obtain engine

Types of changes 🔖

• New feature (non-breaking change which adds functionality)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests

---

Checklist 📝

• This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

[sincewhen]

@yaooqinn please review this PR，thanks

[yaooqinn]

Thank you @sincewhen, let's wait and see the test results

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac388d1) 61.18% compared to head (2152a9b) 61.09%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #6009      +/-   ##
============================================
- Coverage     61.18%   61.09%   -0.09%     
  Complexity       23       23              
============================================
  Files           623      623              
  Lines         37060    37060              
  Branches       5024     5024              
============================================
- Hits          22674    22642      -32     
- Misses        11950    11972      +22     
- Partials       2436     2446      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yaooqinn]

thanks, merged to master

[pan3793]

The closer.lua seems not to work well with the archived package, this causes the CI failure, I am going to revert it to recover CI.

https://github.com/apache/kyuubi/actions/runs/8168780787/job/22331539129?pr=6131

[sincewhen]

The closer.lua seems not to work well with the archived package, this causes the CI failure, I am going to revert it to recover CI.

https://github.com/apache/kyuubi/actions/runs/8168780787/job/22331539129?pr=6131

I see the logs of Flink Test , It seems download flink release file failer . Howerver，I test on my compute , success.

[pan3793]

does it work for older versions? e.g. Spark 3.3.1 or Flink 1.15.0

[pan3793]

For this change itself, unconditionally adding query part ?action=download to the download URL looks incorrect to me, it may break the usage of custom spark.archive.mirror and spark.archive.name.