Close batch session after batch operation completion for idle timeout #5391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
turboFei
force-pushed
the
close_session_with_maxtimeout
branch
from
34bf11b to
5639c7d
Compare
cxzl25
approved these changes
Oct 10, 2023
Codecov Report
@@ Coverage Diff @@
## master #5391 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 588 588
Lines 33406 33427 +21
Branches 4388 4393 +5
======================================
- Misses 33406 33427 +21
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bowenliang123
approved these changes
Oct 10, 2023
pan3793
approved these changes
Oct 10, 2023
pan3793
pushed a commit
that referenced
this pull request
Oct 10, 2023
…or idle timeout ### _Why are the changes needed?_ To add a limitation for batch session lifecycle. otherwise, the batch session might always alive. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ No. Closes #5391 from turboFei/close_session_with_maxtimeout. Closes #5391 5639c7d [fwang12] session no op Authored-by: fwang12 <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit e1d213e) Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
To add a limitation for batch session lifecycle. otherwise, the batch session might always alive.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?
No.