loads the interval of sessionConfCache from configurable file in FileSessionConfAdvisor #5999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SessionConfAdvisor
zhaohehuhu
changed the title
|
@pan3793 plz review it. Thanks! |
yaooqinn
approved these changes
Jan 19, 2024
pan3793
pushed a commit
that referenced
this pull request
Jan 19, 2024
…le file in FileSessionConfAdvisor # 🔍 Description ## Issue References 🔗 This pull request fixes the issue that FileSessionConfAdvisor failed to load the interval defined in configuration file. ## Describe Your Solution 🔧 load the Kyuubi configuration from configurable file instead of using environment parameters. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #5999 from zhaohehuhu/dev-0119. Closes #5999 592d15a [hezhao2] loads the interval of sessionConfCache from configurable file in FileSessionConfAdvisor Authored-by: hezhao2 <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 5d73800) Signed-off-by: Cheng Pan <[email protected]>
|
Thanks, merged to master/1.8 |
zhaohehuhu
added a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Feb 5, 2024
…igurable file in FileSessionConfAdvisor # 🔍 Description ## Issue References 🔗 This pull request fixes the issue that FileSessionConfAdvisor failed to load the interval defined in configuration file. ## Describe Your Solution 🔧 load the Kyuubi configuration from configurable file instead of using environment parameters. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#5999 from zhaohehuhu/dev-0119. Closes apache#5999 592d15a [hezhao2] loads the interval of sessionConfCache from configurable file in FileSessionConfAdvisor Authored-by: hezhao2 <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
zhaohehuhu
added a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
…igurable file in FileSessionConfAdvisor # 🔍 Description ## Issue References 🔗 This pull request fixes the issue that FileSessionConfAdvisor failed to load the interval defined in configuration file. ## Describe Your Solution 🔧 load the Kyuubi configuration from configurable file instead of using environment parameters. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#5999 from zhaohehuhu/dev-0119. Closes apache#5999 592d15a [hezhao2] loads the interval of sessionConfCache from configurable file in FileSessionConfAdvisor Authored-by: hezhao2 <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes the issue that FileSessionConfAdvisor failed to load the interval defined in configuration file.
Describe Your Solution 🔧
load the Kyuubi configuration from configurable file instead of using environment parameters.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.