[KYUUBI #5509][FOLLOWUP] JDBC IT should always depends on kyuubi-hive-jdbc-shaded #6135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i-hive-jdbc-shaded
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6135 +/- ##
============================================
+ Coverage 61.11% 61.13% +0.01%
Complexity 23 23
============================================
Files 624 624
Lines 37260 37260
Branches 5046 5046
============================================
+ Hits 22772 22779 +7
+ Misses 12025 12017 -8
- Partials 2463 2464 +1 ☔ View full report in Codecov by Sentry. |
cxzl25
approved these changes
Mar 7, 2024
|
Thanks, merged to master |
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
…i-hive-jdbc-shaded # 🔍 Description ## Issue References 🔗 `build/dist` is going to fail without profile `-Pjdbc-shaded` after bumping a new version. ## Describe Your Solution 🔧 Making the JDBC IT module always depends on `kyuubi-hive-jdbc-shaded`, to ensure the shaded JDBC is packaged before the JDBC IT module performs copy jars. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 Bump a new version, then perform making the distribution. ``` build/mvn versions:set -DgenerateBackupPoms=false -DnewVersion="1.9.1-SNAPSHOT" build/dist --spark-provided --hive-provided --flink-provided ``` Before, failed with ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.6.1:copy (copy) on project kyuubi-jdbc-it_2.12: Unable to find/resolve artifact.: Could not find artifact org.apache.kyuubi:kyuubi-hive-jdbc-shaded🫙1.9.1-SNAPSHOT in aliyun-apache-snapshots (https://maven.aliyun.com/repository/apache-snapshots/) -> [Help 1] ``` After, everything goes well. --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6135 from pan3793/impala-folowup. Closes apache#5509 12f600d [Cheng Pan] [KYUUBI apache#5509][FOLLOWUP] JDBC IT should always depends on kyuubi-hive-jdbc-shaded Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
build/distis going to fail without profile-Pjdbc-shadedafter bumping a new version.Describe Your Solution 🔧
Making the JDBC IT module always depends on
kyuubi-hive-jdbc-shaded, to ensure the shaded JDBC is packaged before the JDBC IT module performs copy jars.Types of changes 🔖
Test Plan 🧪
Bump a new version, then perform making the distribution.
Before, failed with
After, everything goes well.
Checklist 📝
Be nice. Be informative.