Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDBC engine using the overlay conf as session conf #6182

Closed
wants to merge 1 commit into from

Conversation

lsm1
Copy link
Contributor

@lsm1 lsm1 commented Mar 14, 2024

🔍 Description

Issue References 🔗

Describe Your Solution 🔧

Like #6147, JDBC engine should overwriting the engine conf with the passed conf consider as the full session conf.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.43%. Comparing base (c1239f2) to head (9ca8b48).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6182      +/-   ##
============================================
- Coverage     58.46%   58.43%   -0.03%     
  Complexity       24       24              
============================================
  Files           649      649              
  Lines         39312    39312              
  Branches       5415     5415              
============================================
- Hits          22982    22973       -9     
- Misses        13859    13865       +6     
- Partials       2471     2474       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan3793 pan3793 closed this in f4f7956 Mar 19, 2024
pan3793 pushed a commit that referenced this pull request Mar 19, 2024
# 🔍 Description
## Issue References 🔗

## Describe Your Solution 🔧

Like #6147, JDBC engine should overwriting the engine conf with the passed conf consider as the full session conf.

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6182 from lsm1/branch-jdbc-engine-use-overlay-conf.

Closes #6182

9ca8b48 [senmiaoliu] Using the overlay conf as session conf

Authored-by: senmiaoliu <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit f4f7956)
Signed-off-by: Cheng Pan <[email protected]>
pan3793 pushed a commit that referenced this pull request Mar 19, 2024
# 🔍 Description
## Issue References 🔗

## Describe Your Solution 🔧

Like #6147, JDBC engine should overwriting the engine conf with the passed conf consider as the full session conf.

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6182 from lsm1/branch-jdbc-engine-use-overlay-conf.

Closes #6182

9ca8b48 [senmiaoliu] Using the overlay conf as session conf

Authored-by: senmiaoliu <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit f4f7956)
Signed-off-by: Cheng Pan <[email protected]>
pan3793 pushed a commit that referenced this pull request Mar 19, 2024
# 🔍 Description
## Issue References 🔗

## Describe Your Solution 🔧

Like #6147, JDBC engine should overwriting the engine conf with the passed conf consider as the full session conf.

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6182 from lsm1/branch-jdbc-engine-use-overlay-conf.

Closes #6182

9ca8b48 [senmiaoliu] Using the overlay conf as session conf

Authored-by: senmiaoliu <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
@pan3793 pan3793 added this to the v1.8.2 milestone Mar 19, 2024
@pan3793
Copy link
Member

pan3793 commented Mar 19, 2024

Merged to master/1.9.1/1.8.2

zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this pull request Mar 21, 2024
# 🔍 Description
## Issue References 🔗

## Describe Your Solution 🔧

Like apache#6147, JDBC engine should overwriting the engine conf with the passed conf consider as the full session conf.

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6182 from lsm1/branch-jdbc-engine-use-overlay-conf.

Closes apache#6182

9ca8b48 [senmiaoliu] Using the overlay conf as session conf

Authored-by: senmiaoliu <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants