-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDBC engine using the overlay conf as session conf #6182
Closed
Closed
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6182 +/- ##
============================================
- Coverage 58.46% 58.43% -0.03%
Complexity 24 24
============================================
Files 649 649
Lines 39312 39312
Branches 5415 5415
============================================
- Hits 22982 22973 -9
- Misses 13859 13865 +6
- Partials 2471 2474 +3 ☔ View full report in Codecov by Sentry. |
cxzl25
approved these changes
Mar 14, 2024
pan3793
approved these changes
Mar 19, 2024
pan3793
pushed a commit
that referenced
this pull request
Mar 19, 2024
# 🔍 Description ## Issue References 🔗 ## Describe Your Solution 🔧 Like #6147, JDBC engine should overwriting the engine conf with the passed conf consider as the full session conf. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6182 from lsm1/branch-jdbc-engine-use-overlay-conf. Closes #6182 9ca8b48 [senmiaoliu] Using the overlay conf as session conf Authored-by: senmiaoliu <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit f4f7956) Signed-off-by: Cheng Pan <[email protected]>
pan3793
pushed a commit
that referenced
this pull request
Mar 19, 2024
# 🔍 Description ## Issue References 🔗 ## Describe Your Solution 🔧 Like #6147, JDBC engine should overwriting the engine conf with the passed conf consider as the full session conf. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6182 from lsm1/branch-jdbc-engine-use-overlay-conf. Closes #6182 9ca8b48 [senmiaoliu] Using the overlay conf as session conf Authored-by: senmiaoliu <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit f4f7956) Signed-off-by: Cheng Pan <[email protected]>
pan3793
pushed a commit
that referenced
this pull request
Mar 19, 2024
# 🔍 Description ## Issue References 🔗 ## Describe Your Solution 🔧 Like #6147, JDBC engine should overwriting the engine conf with the passed conf consider as the full session conf. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6182 from lsm1/branch-jdbc-engine-use-overlay-conf. Closes #6182 9ca8b48 [senmiaoliu] Using the overlay conf as session conf Authored-by: senmiaoliu <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
Merged to master/1.9.1/1.8.2 |
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
# 🔍 Description ## Issue References 🔗 ## Describe Your Solution 🔧 Like apache#6147, JDBC engine should overwriting the engine conf with the passed conf consider as the full session conf. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6182 from lsm1/branch-jdbc-engine-use-overlay-conf. Closes apache#6182 9ca8b48 [senmiaoliu] Using the overlay conf as session conf Authored-by: senmiaoliu <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
Describe Your Solution 🔧
Like #6147, JDBC engine should overwriting the engine conf with the passed conf consider as the full session conf.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.