Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TerminalOutput.pathToMaven() more robust to avoid #929 #930

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Apr 12, 2024

Mitigates #929 but does not have an ambition to find the root cause.

@gastaldi
Copy link
Member

It would be nice to log (debug?) when the URL is malformed

@ppalaga
Copy link
Contributor Author

ppalaga commented Apr 12, 2024

It would be nice to log (debug?) when the URL is malformed

Well, the issue we are mitigating happens only in the text UI, where the place is sparse and where there is no concept of log level. I am not sure the information that we were not able to parse some URL is that interesting to end users. If we cannot parse it, we just print it as is. If the transfer failure matters, the daemon will inform them through a separate message. If it is ignorable, I do not think they need to know. My 2c.

Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Next maven resolver will probably have a better way to access this information with apache/maven-resolver#474, so we'll be able to update to that one when it's integrated into 3.9.x and 4.x maven branches.

@ppalaga ppalaga merged commit 73bfecb into apache:master Apr 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants