[MRESOLVER-540] TransferResource can reveal more about resource #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide means and extra information about the resource being transfered. --- https://issues.apache.org/jira/browse/MRESOLVER-540
|
Main inspiration is to make stunts like these not required: apache/maven-mvnd#930 |
gnodet
reviewed
Apr 18, 2024
| * | ||
| * @since 2.0.0 | ||
| */ | ||
| public enum ResourceType { |
There was a problem hiding this comment.
I wonder if that one is really needed, as one could use instanceof on the resource (and a cast will be needed anyway)...
There was a problem hiding this comment.
I kinda agree with you, moreover as these events are emitted ONLY by connector. For example, Transport API of Maven4 completely circumvents connector, and goes directly to transport... so yeah, due this (connector) type can really only be Artifact or Metadata
gnodet
approved these changes
Apr 18, 2024
|
Will remove/simplify it |
|
Simplified, removed cruft and is now simple and nice. @gnodet pls review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide extra information about the resource being transferred.
https://issues.apache.org/jira/browse/MRESOLVER-540