feat(core): add if_not_exist in OpWrite
#5305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keming <[email protected]>
Xuanwo
reviewed
Nov 11, 2024
core/src/types/operator/operator.rs
Outdated
| @@ -1254,6 +1254,25 @@ impl Operator { | |||
| /// # } | |||
| /// ``` | |||
| /// | |||
| /// ## `if_not_exist` | |||
| /// | |||
| /// Set `if_not_exist` for this `write` request. This can be treated as a simplified version | |||
There was a problem hiding this comment.
Hi, if_not_exist is not the same feature as if_none_match. For example, S3 only supports if_not_exist but not if_none_match. We should eliminate use cases like if_none_match("*") to clarify this.
All existing tests and docs should replace by if_not_exist instead.
There was a problem hiding this comment.
I'm not familiar with the current usage of if_none_match. I can find it in op read/stat/write.
- Should we keep the tests since we still allow users to use this option?
- Do you mean that we should delete the
if_none_matchfrom the write-op-related docs?
There was a problem hiding this comment.
- Should we keep the tests since we still allow users to use this option?
The tests using if_none_match("*") should be removed since we can't guarantee that all services will support this.
- Do you mean that we should delete the
if_none_matchfrom the write-op-related docs?
We can retain this docs, but we need to remove the if_none_match("*") example. Instead, we should use an etag to clarify that we are accepting an etag.
Signed-off-by: Keming <[email protected]>
Signed-off-by: Keming <[email protected]>
Signed-off-by: Keming <[email protected]>
kemingy
force-pushed
the
if_not_exist
branch
from
248630e to
302ea26
Compare
Xuanwo
reviewed
Nov 12, 2024
Xuanwo
reviewed
Nov 12, 2024
Signed-off-by: Keming <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5286.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
Add
op.write_with(path, bs).if_not_exists(true)