Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add
if_not_exist
inOpWrite
#5305feat(core): add
if_not_exist
inOpWrite
#5305Changes from 1 commit
0b131ec
1272ff1
ce87b81
302ea26
aecaeeb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
if_not_exist
is not the same feature asif_none_match
. For example, S3 only supportsif_not_exist
but notif_none_match
. We should eliminate use cases likeif_none_match("*")
to clarify this.All existing tests and docs should replace by
if_not_exist
instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the current usage of
if_none_match
. I can find it in op read/stat/write.if_none_match
from the write-op-related docs?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests using
if_none_match("*")
should be removed since we can't guarantee that all services will support this.We can retain this docs, but we need to remove the
if_none_match("*")
example. Instead, we should use anetag
to clarify that we are accepting anetag
.