-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update release.md #5431
docs: Update release.md #5431
Conversation
@@ -139,11 +139,10 @@ For example: | |||
Bump all components' version in the project to the new opendal version. | |||
Please note that this version is the exact version of the release, not the release candidate version. | |||
|
|||
- rust core: bump version in `Cargo.toml` | |||
- cpp binding: bump version in `bindings/cpp/CMakeLists.txt` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed. I don't see such a version field anymore.
cc @PragmaTwice is this the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the case?
That we don't have a version field for Opendal C++ binding in CMakeLists.txt, and it's intended.
If so, I'd like to know the reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not so common to maintain such VERSION field in project()
in C++ project.
I think I remove it since the version number is stale. You can add it again if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want.
No need :D
not so common to maintain such VERSION
May I ask what is the common practice to version a C++ project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there's a common practice, it can be just git tags, or text files, or generate by scripts, e.g. https://github.com/ClickHouse/ClickHouse/blob/8a04621f436a36b35346ff474fb980469b61647d/cmake/autogenerated_versions.txt#L1 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get it.
No, we don't have such things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating this.
@Xuanwo do we have a script to update Cargo.toml's version now? If so, perhaps we can add those bindings' version bump also.