Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update release.md #5431

Merged
merged 1 commit into from
Dec 19, 2024
Merged

docs: Update release.md #5431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions website/community/release/release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,10 @@ For example:
Bump all components' version in the project to the new opendal version.
Please note that this version is the exact version of the release, not the release candidate version.

- rust core: bump version in `Cargo.toml`
- cpp binding: bump version in `bindings/cpp/CMakeLists.txt`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. I don't see such a version field anymore.

cc @PragmaTwice is this the case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the case?

That we don't have a version field for Opendal C++ binding in CMakeLists.txt, and it's intended.

If so, I'd like to know the reason.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not so common to maintain such VERSION field in project() in C++ project.

I think I remove it since the version number is stale. You can add it again if you want.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want.

No need :D

not so common to maintain such VERSION

May I ask what is the common practice to version a C++ project?

Copy link
Member

@PragmaTwice PragmaTwice Dec 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's a common practice, it can be just git tags, or text files, or generate by scripts, e.g. https://github.com/ClickHouse/ClickHouse/blob/8a04621f436a36b35346ff474fb980469b61647d/cmake/autogenerated_versions.txt#L1 .

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get it.

- haskell binding: bump version and update the `tag` field of `source-repository this` in `bindings/haskell/opendal.cabal`
- java binding: bump version in `bindings/java/pom.xml`
- node.js binding: bump version in `bindings/nodejs/package.json` and `bindings/nodejs/npm/*/package.json`
- Rust core: Bump version in `Cargo.toml`
- Haskell binding: Bump version and update the `tag` field of `source-repository this` in `bindings/haskell/opendal.cabal`
- Java binding: Bump version in `bindings/java/pom.xml`
- Node.js binding: Bump version in `bindings/nodejs/package.json` and `bindings/nodejs/npm/*/package.json`

### Update docs

Expand Down
Loading