Revert "[Netty] Fix client with TLS and custom SSL context" #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
requested review from
He-Pin,
nvollmar,
mdedetrich and
samueleresca
samueleresca
approved these changes
Dec 25, 2023
This was referenced Dec 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #197
the OP of #197 copied license incompatible code from akka-grpc - completely unacceptable
the code might be short but the OP kept the comments exactly the same as the akka comments making it obvious that the code is not his
Pekko contributors - anyone else who reads the akka-grpc code will become unavailable to review or contribute to fixing the original issue
We need a clean room fix.