Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close gradle build stream in finally block #214

Merged

Conversation

mdedetrich
Copy link
Contributor

Self explanatory

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mdedetrich mdedetrich merged commit de8f2f2 into apache:main Jan 24, 2024
17 checks passed
@mdedetrich mdedetrich deleted the close-gradle-build-stream-in-finally-block branch January 24, 2024 13:15
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - but closing ByteArrayOutputStream is not massively important - unlike most OutputStreams

@mdedetrich
Copy link
Contributor Author

Yeah I just realized that after, in any case its harmless either way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants