Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close gradle build stream in finally block #214

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Close gradle build stream in finally block #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions gradle-plugin/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,16 @@ group = "org.apache.pekko"

def getVersionFromParentSbtBuild() {
ByteArrayOutputStream os = new ByteArrayOutputStream()
String parentDir = project.rootDir.getParentFile().getPath()
exec {
workingDir parentDir
commandLine 'sbt', '--no-colors', '--error', 'set aggregate := false; print version'
standardOutput os
try {
String parentDir = project.rootDir.getParentFile().getPath()
exec {
workingDir parentDir
commandLine 'sbt', '--no-colors', '--error', 'set aggregate := false; print version'
standardOutput os
}
} finally {
os.close()
}
os.close()
String finalVersion = os.toString().trim()
project.logger.info("Derived gradle version from parent sbt build: $finalVersion")
return finalVersion
Expand Down