change pom name

[pjfanning]

use gRPC to match the usual style

[mdedetrich]

I don't have an issue with this, but then we should also override the apacheSonatypeArtifactNameProcessor for this project so that the gRPC part of the name is consistent.

Otherwise it will be mismatched in gradle versus the rest of the project. You can see https://github.com/mdedetrich/sbt-apache-sonatype/blob/160a1577519f1527644b83831b240fa07ea0b347/src/main/scala/org/mdedetrich/apache/sonatype/ApacheSonatypePlugin.scala#L35-L43 for the default implementation.

[He-Pin]

the text below is gRPC, so I +1 for this.

[He-Pin]

and the Logo is GRPC :)! maybe it's fine. will this name cause any trademark issue?

[He-Pin]

and it was "pekko-grpc-gradle-plugin".

[pjfanning]

I understand that we don't want to complicate the sbt plugin to cover the case issue but there is no absolute requirement that this gradle-plugin pom needs to match the other poms.

[mdedetrich]

I understand that we don't want to complicate the sbt plugin to cover the case issue but there is no absolute requirement that this gradle-plugin pom needs to match the other poms.

You can easily add it in this project, just do

ThisBuild / apacheSonatypeArtifactNameProcessor := { artifactId =>
  val prettified = artifactId
    .replaceAll("-", " ")
    .replaceAll("_", " ")
    .split(" ")
    .map(_.capitalize)
    .mkString(" ")
    .replaceAll("Grpc", "gRPC")
  if (prettified.startsWith("Apache ")) prettified else s"Apache $prettified"
}

in build.sbt. Thats why the setting is configurable. Or an even simpler variant is

ThisBuild / apacheSonatypeArtifactNameProcessor := {
  apacheSonatypeArtifactNameProcessor.value andThen { prettied => prettied.replaceAll("Grpc", "gRPC") }
}

[mdedetrich]

@pjfanning I have pushed a commit that also uses fixes this name for the rest of the sbt modules

[He-Pin]

Lgtm

[He-Pin]

Looks great, but better if it match something like GRPC too.

[pjfanning]

the built plugin title cases the name - so Grpc is what is expected - making this case insensitive is complicated and not worth the hassle

[mdedetrich]

@pjfanning You want to merge this or you still waiting on something?

[pjfanning]

merged