Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change pom name #216

Merged
merged 2 commits into from
Jan 25, 2024
Merged

change pom name #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46719c4
add Apache to pom name
pjfanning Jan 24, 2024
e0a9692
Also fix gRPC for sbt modules
mdedetrich Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ commands := commands.value.filterNot { command =>

ThisBuild / reproducibleBuildsCheckResolver := Resolver.ApacheMavenStagingRepo

// So that gRPC is properly styled
ThisBuild / apacheSonatypeArtifactNameProcessor := apacheSonatypeArtifactNameProcessor.value.andThen {
_.replaceAll("Grpc", "gRPC")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but better if it match something like GRPC too.

Copy link
Contributor Author

@pjfanning pjfanning Jan 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the built plugin title cases the name - so Grpc is what is expected - making this case insensitive is complicated and not worth the hassle

}

val pekkoPrefix = "pekko-grpc"
val pekkoGrpcRuntimeName = s"$pekkoPrefix-runtime"

Expand Down
2 changes: 1 addition & 1 deletion gradle-plugin/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ gradlePlugin {
publishing {
publications.withType(MavenPublication) {
pom {
name = "Apache Pekko Grpc Gradle Plugin"
name = "Apache Pekko gRPC Gradle Plugin"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the text below is gRPC, so I +1 for this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
and the Logo is GRPC :)! maybe it's fine. will this name cause any trademark issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and it was "pekko-grpc-gradle-plugin".

description = "Apache Pekko gRPC - Support for building streaming gRPC servers and clients on top of Pekko Streams."
url = "https://pekko.apache.org/"
licenses {
Expand Down
Loading