Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add badges to README + links to Zulip #180

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Add badges to README + links to Zulip #180

merged 1 commit into from
Aug 26, 2024

Conversation

snazy
Copy link
Member

@snazy snazy commented Aug 22, 2024

No description provided.

jbonofre
jbonofre previously approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be rebase on the "new" README.md when merged, but good to me.

@snazy
Copy link
Member Author

snazy commented Aug 22, 2024

It should be rebase on the "new" README.md when merged, but good to me.

Definitely - and I want to add some "textual links" once all that's in.

@snazy snazy changed the title Add badges to README Add badges to README + links to Zulip Aug 22, 2024
@snazy snazy marked this pull request as ready for review August 22, 2024 18:00
@snazy snazy mentioned this pull request Aug 23, 2024
Open
@RussellSpitzer
Copy link
Member

Thanks @snazy , and thanks @eric-maynard and @ebyhr for reviewing

@RussellSpitzer RussellSpitzer merged commit ddc6649 into apache:main Aug 26, 2024
3 checks passed
@snazy snazy deleted the readme-badges branch August 26, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussellSpitzer RussellSpitzer RussellSpitzer approved these changes

@ebyhr ebyhr ebyhr approved these changes

@eric-maynard eric-maynard eric-maynard approved these changes

@jbonofre jbonofre jbonofre left review comments

@ashvina ashvina Awaiting requested review from ashvina ashvina is a code owner

@vvcephei vvcephei Awaiting requested review from vvcephei vvcephei is a code owner

@jackye1995 jackye1995 Awaiting requested review from jackye1995 jackye1995 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@snazy @RussellSpitzer @jbonofre @ebyhr @eric-maynard