Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update created-at property in createTableDirectWithWriteDelegation + enable ErrorProne ModifiedButNotUsed #207

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

ebyhr
Copy link
Contributor

@ebyhr ebyhr commented Aug 25, 2024

Description

Update created-at property in createTableDirectWithWriteDelegation + enable ErrorProne ModifiedButNotUsed

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code

Copy link
Contributor

@flyrain flyrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks for the fix!

@snazy
Copy link
Member

snazy commented Aug 27, 2024

Looks like this PR needs a rebase now

@ebyhr
Copy link
Contributor Author

ebyhr commented Aug 27, 2024

Rebased on main branch :)

@snazy snazy enabled auto-merge (squash) August 27, 2024 07:18
@snazy snazy merged commit 859d303 into apache:main Aug 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants