Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][fn] add docs for supporting reading config options from files in Python runner #544

Merged
merged 4 commits into from
May 4, 2023

Conversation

Anonymitaet
Copy link
Member

@Anonymitaet Anonymitaet commented Apr 27, 2023

This PR adds docs for apache/pulsar#18951. It is based on the tech inputs provided by @tpiperatgod in #541

  • doc

cc @D-2-Ed for editorial review, thanks!

@github-actions github-actions bot added the doc Improvements or additions to documentation label Apr 27, 2023
@Anonymitaet
Copy link
Member Author

Anonymitaet commented Apr 27, 2023

Hi @tpiperatgod, I submit this PR since it's more convenient to show you my thoughts and preview.

Preview

image

Doc changes explanations

2️⃣3️⃣ in the image above
I've restricted the doc structure by "showing the example first" and then "explaining the details".

Reasons:

  1. Most developers are likely "learning by doing" rather than "learning by reading". Examples always attract them the most. "Hook them up" first and then they have more patience to read it through.

  2. The doc structure is more clear. The beginning is the example, and the latter is the explanation. Splitting them up can increase readability.

1️⃣

Consolidate the note into running text to accommodate the new structure.

I've also made other changes like updating all future tense to present tense since "Write in the simple present tense as much as possible if you are covering facts that were, are, and forever shall be true" is a rule in technical writing.

Question

4️⃣

Seems that the explanations in this box is contradictory.

The above indicates "--config-file" override "command-line", but the below says the opposite. Can you clarify a bit and give some examples? Thank you!

@tpiperatgod
Copy link

lgtm

And for question 4:

I made a mistake in the first sentence, it should be that the parameters passed in from the command line have a higher priority.

Thank you for the review and the advice on technical writing!

@Anonymitaet
Copy link
Member Author

@tpiperatgod thanks for your quick response!

it should be that the parameters passed in from the command line have a higher priority.

Does that mean I can delete the 1st sentence and only keep the 2nd one?

@tpiperatgod
Copy link

Yes

@Anonymitaet
Copy link
Member Author

Yes

Done, PTAL.

@Anonymitaet Anonymitaet added this to the 3.0.0 milestone Apr 28, 2023
@Anonymitaet
Copy link
Member Author

@momo-jun @Huanli-Meng could you please help review? Thank you!

Copy link
Contributor

@momo-jun momo-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, with a couple of suggestions.

@Anonymitaet Anonymitaet merged commit 0577919 into apache:main May 4, 2023
@tisonkun
Copy link
Member

tisonkun commented May 8, 2023

site2/website-next/yarn.lock is checked in unintentionally. Reverting...

@tisonkun tisonkun mentioned this pull request May 8, 2023
4 tasks
@Anonymitaet
Copy link
Member Author

@tisonkun Oops! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants