-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][fn] support reading config options from file in Function Python Runner #18951
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18951 +/- ##
============================================
- Coverage 64.20% 63.17% -1.03%
+ Complexity 26265 25952 -313
============================================
Files 1832 1832
Lines 134067 134068 +1
Branches 14753 14753
============================================
- Hits 86077 84704 -1373
- Misses 40135 41661 +1526
+ Partials 7855 7703 -152
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pulsar-functions/instance/src/main/python/python_instance_main.py
Outdated
Show resolved
Hide resolved
e92efe8
to
ea58755
Compare
The pr had no activity for 30 days, mark with Stale label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please add some tests?
pulsar-functions/instance/src/main/python/python_instance_main.py
Outdated
Show resolved
Hide resolved
93c64da
to
660c540
Compare
…e configuration from the configuration file Signed-off-by: laminar <[email protected]>
Signed-off-by: laminar <[email protected]>
Signed-off-by: laminar <[email protected]>
Signed-off-by: laminar <[email protected]>
Signed-off-by: laminar <[email protected]>
Signed-off-by: laminar <[email protected]>
Signed-off-by: laminar <[email protected]>
Signed-off-by: laminar <[email protected]>
660c540
to
5e4c381
Compare
Hi @tpiperatgod, did you have any plans to update the related docs? |
I will try to submit a PR for the document, please help me review it then, thanks. |
@tpiperatgod I'm happy to help. Feel free to ping me. |
Hi @tpiperatgod 3.0 is planned to be released on May 2. We're aiming to align docs with code. Can you share some progress on the doc? TIA!
|
@Anonymitaet Here is the docs pr, please help review: apache/pulsar-site#541 |
@tpiperatgod thanks for your technical input! I've restructured the docs based on user learning habits and raised a question in apache/pulsar-site#544 (comment), PTAL. |
Fixes #18533
Master Issue: #xyz
Motivation
please refer to this proposal: #18744
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: tpiperatgod#11