Skip to content

Conversation

@kumaab
Copy link
Contributor

@kumaab kumaab commented Oct 24, 2025

What changes were proposed in this pull request?

Use a large runner as currently the runner for docker image build is running out of disk space.

How was this patch tested?

CI

@kumaab kumaab self-assigned this Oct 24, 2025
Copy link
Contributor

@vyommani vyommani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall! 👍

Just one question: Any specific reason for bumping the timeout to 60 minutes?
The previous value was 30 min — is the Docker build now taking significantly longer (e.g. due to larger images, more layers, or slower network pulls)? If so, it’d be helpful to add a brief comment in the YAML explaining the increase for future maintainers.

Otherwise, feel free to merge!

@kumaab kumaab changed the title Change runner to ubuntu-22.04-32core for docker-build RANGER-5385: Update runner for docker-build Oct 25, 2025
@kumaab
Copy link
Contributor Author

kumaab commented Oct 25, 2025

LGTM overall! 👍

Just one question: Any specific reason for bumping the timeout to 60 minutes? The previous value was 30 min — is the Docker build now taking significantly longer (e.g. due to larger images, more layers, or slower network pulls)? If so, it’d be helpful to add a brief comment in the YAML explaining the increase for future maintainers.

Otherwise, feel free to merge!

It seems that the docker build itself is not taking any longer - this is similar to earlier runs, but bringing up containers with health checks post docker-build might be consuming more time, hence the decision to bump up the timeout.
Yeah, will add a comment on this, thanks!

Bump OS version to ubuntu-24.04 for more disk space and increase timeout to allow containers to come up.
@kumaab kumaab merged commit eee8902 into master Oct 27, 2025
4 of 6 checks passed
@kumaab kumaab deleted the large_runner_docker branch October 27, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants