RATIS-2131: Surround with [] only if hostName is a IPv6 string #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified with Apache Celeborn, which uses 3.1.0 |
|
+CC @waitinfuture, @RexXiong |
|
+CC @szetszwo based on git blame. |
szetszwo
approved these changes
Jul 25, 2024
|
Thanks @szetszwo ! |
szetszwo
pushed a commit
that referenced
this pull request
Aug 22, 2024
mridulm
pushed a commit
to apache/celeborn
that referenced
this pull request
Sep 26, 2024
### What changes were proposed in this pull request? Bump Ratis version from 3.1.0 to 3.1.1 including: - Remove `address2String` and use `setAddress(ratisAddr)` with the release of apache/ratis#1125. - Support `raft.grpc.message.size.max` must be 1m larger than `raft.server.log.appender.buffer.byte-limit` for apache/ratis#1132. ### Why are the changes needed? Bump Ratis version from 3.1.0 to 3.1.1. Ratis has released v3.1.1, of which release note refers to [3.1.1](https://ratis.apache.org/post/3.1.1.html). The 3.1.1 version is a minor release with multiple improvements and bugfixes including [[RATIS-2116] Fix the issue where RaftServerImpl.appendEntries may be blocked indefinitely](https://issues.apache.org/jira/browse/RATIS-2116), [[RATIS-2131] Configuring Ratis fails when hostname is used, and is an IPv6 host](https://issues.apache.org/jira/browse/RATIS-2131). See the [changes between 3.1.0 and 3.1.1](apache/ratis@ratis-3.1.0...ratis-3.1.1) releases. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI. Closes #2759 from SteNicholas/CELEBORN-1525. Authored-by: SteNicholas <[email protected]> Signed-off-by: Mridul Muralidharan <mridul<at>gmail.com>
HolyLow
pushed a commit
to HolyLow/celeborn
that referenced
this pull request
Oct 14, 2024
### What changes were proposed in this pull request? Bump Ratis version from 3.1.0 to 3.1.1 including: - Remove `address2String` and use `setAddress(ratisAddr)` with the release of apache/ratis#1125. - Support `raft.grpc.message.size.max` must be 1m larger than `raft.server.log.appender.buffer.byte-limit` for apache/ratis#1132. ### Why are the changes needed? Bump Ratis version from 3.1.0 to 3.1.1. Ratis has released v3.1.1, of which release note refers to [3.1.1](https://ratis.apache.org/post/3.1.1.html). The 3.1.1 version is a minor release with multiple improvements and bugfixes including [[RATIS-2116] Fix the issue where RaftServerImpl.appendEntries may be blocked indefinitely](https://issues.apache.org/jira/browse/RATIS-2116), [[RATIS-2131] Configuring Ratis fails when hostname is used, and is an IPv6 host](https://issues.apache.org/jira/browse/RATIS-2131). See the [changes between 3.1.0 and 3.1.1](apache/ratis@ratis-3.1.0...ratis-3.1.1) releases. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI. Closes apache#2759 from SteNicholas/CELEBORN-1525. Authored-by: SteNicholas <[email protected]> Signed-off-by: Mridul Muralidharan <mridul<at>gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, if the address is IPv6, NetUtils.address2String always surrounds it with '[]'.
This should be done only when the input is an IP string, and not for hostnames (which have an IPv6 address)
What is the link to the Apache JIRA
RATIS-2131
How was this patch tested?
Manual testing