[SPARK-51563][SQL] Support the fully qualified type name TIME(n) WITHOUT TIME ZONE #51177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
MaxGekk
changed the title
|
@srielau @cloud-fan Please, have a look at the PR. |
srielau
approved these changes
Jun 14, 2025
LuciferYang
approved these changes
Jun 14, 2025
|
Merging to master. Thank you, @srielau and @LuciferYang for review. |
|
late LGTM |
I have opened the PR for that: #51181 |
MaxGekk
added a commit
that referenced
this pull request
Jun 17, 2025
### What changes were proposed in this pull request? In the PR, I propose to introduce a synonym for the existing type `TIMESTAMP_NTZ` as the SQL standard defines: `TIMESTAMP WITHOUT TIME ZONE`. ### Why are the changes needed? - To conform to the SQL standard - To simplify migration from other systems that recognize the fully qualified type name. - To be consistent with the `TIME` type, see #51177 ### Does this PR introduce _any_ user-facing change? No, it just extends the existing syntax. ### How was this patch tested? By running the modified test suite: ``` $ build/sbt "test:testOnly *DataTypeParserSuite" ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #51181 from MaxGekk/timestamp-without-timezone. Authored-by: Max Gekk <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to recognize the optional suffix
WITHOUT TIME ZONEof the typeTIME(n), and considerTIME(n) WITHOUT TIME ZONEandTIME(n)as synonyms.Why are the changes needed?
To conform to the ANSI SQL standard.
Does this PR introduce any user-facing change?
No. It just extends the existing syntax.
How was this patch tested?
By running the affected test suites:
Was this patch authored or co-authored using generative AI tooling?
No.