Skip to content

[SPARK-52493][SQL] Support TIMESTAMP WITHOUT TIME ZONE #51181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

MaxGekk
Copy link
Member

@MaxGekk MaxGekk commented Jun 14, 2025

What changes were proposed in this pull request?

In the PR, I propose to introduce a synonym for the existing type TIMESTAMP_NTZ as the SQL standard defines: TIMESTAMP WITHOUT TIME ZONE.

Why are the changes needed?

Does this PR introduce any user-facing change?

No, it just extends the existing syntax.

How was this patch tested?

By running the modified test suite:

$ build/sbt "test:testOnly *DataTypeParserSuite"

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the SQL label Jun 14, 2025
@MaxGekk MaxGekk changed the title [WIP][SQL] Support TIMESTAMP WITHOUT TIME ZONE [SPARK-52493][SQL] Support TIMESTAMP WITHOUT TIME ZONE Jun 16, 2025
@MaxGekk MaxGekk marked this pull request as ready for review June 16, 2025 17:03
@MaxGekk
Copy link
Member Author

MaxGekk commented Jun 16, 2025

@srielau Please, take a look at the PR. Also cc @gengliangwang.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @MaxGekk .

@dongjoon-hyun
Copy link
Member

cc @yaooqinn

Copy link
Member

@yaooqinn yaooqinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you @MaxGekk and @dongjoon-hyun

@MaxGekk
Copy link
Member Author

MaxGekk commented Jun 17, 2025

Merging to master. Thank you, @dongjoon-hyun @yaooqinn @gengliangwang for review.

@MaxGekk MaxGekk closed this in 435cb4b Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants